1517468 - about:devtools subscribe button has wrong text color

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[Tim Nguyen :ntim]

This is because about:devtools defines its own primary-button class instead of using the given primary class.

Comment 1

[Tim Nguyen :ntim]

Screenshot: https://bug1516344.bmoattachments.org/attachment.cgi?id=9033239

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1517468 - Reuse common.css classes and variables in about:devtools. r=jdescottes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba4f46bbfdb
Reuse common.css classes and variables in about:devtools. r=jdescottes

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 9035292 [details]
Bug 1517468 - Reuse common.css classes and variables in about:devtools. r=jdescottes

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1473922

User impact if declined: Wrong text color on about:devtools blue buttons

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Go to about:devtools, check the blue buttons text color

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Trivial CSS patch

String changes made/needed: none

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3ba4f46bbfdb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9035292 [details]
Bug 1517468 - Reuse common.css classes and variables in about:devtools. r=jdescottes

[Triage Comment]
Trivial devtools CSS fixup. Approved for 65.0b10.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f5097891fe3

Comment 8

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 66.0a1 (BuildId:20190103220533).

This issue is verified fixed using Firefox 66.0a1 (BuildId:20190111093148) and Firefox 65.0b10 (BuildId:20190110221328) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.