about:devtools subscribe button has wrong text color

VERIFIED FIXED in Firefox 65

Status

defect
P3
normal
VERIFIED FIXED
7 months ago
6 months ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Blocks 1 bug, {regression})

unspecified
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 verified, firefox66 verified)

Details

Attachments

(1 attachment)

This is because about:devtools defines its own primary-button class instead of using the given primary class.
Keywords: regression
Blocks: 1516344
Priority: -- → P3
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3ba4f46bbfdb
Reuse common.css classes and variables in about:devtools. r=jdescottes

Comment on attachment 9035292 [details]
Bug 1517468 - Reuse common.css classes and variables in about:devtools. r=jdescottes

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1473922

User impact if declined: Wrong text color on about:devtools blue buttons

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Go to about:devtools, check the blue buttons text color

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Trivial CSS patch

String changes made/needed: none

Attachment #9035292 - Flags: approval-mozilla-beta?
Assignee: nobody → ntim.bugs
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Comment on attachment 9035292 [details]
Bug 1517468 - Reuse common.css classes and variables in about:devtools. r=jdescottes

[Triage Comment]
Trivial devtools CSS fixup. Approved for 65.0b10.

Attachment #9035292 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have managed to reproduce this issue using Firefox 66.0a1 (BuildId:20190103220533).

This issue is verified fixed using Firefox 66.0a1 (BuildId:20190111093148) and Firefox 65.0b10 (BuildId:20190110221328) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.