Closed Bug 1517476 Opened 6 years ago Closed 5 years ago

[meta] Investigate moving some functions from browser.js into the new address bar code once QuantumBar rewrite is complete

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1610472

People

(Reporter: standard8, Unassigned)

Details

(Keywords: meta)

User Story

- losslessDecodeURI could move to UrlbarUtils, as it is window independent.
-- https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/browser.js#2669 
- URLBarSetURI could move to UrlbarInput. 
-- https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/base/content/browser.js#2621
-- isInitialPage should move with it
-- checkEmptyPageOrigin / SetPageProxyState may be able to move, but needs some investigation.
There's a few functions that I think we should investigate moving into the new QuantumBar code once the new code is enabled by default. Some of these are still used in the existing urlbarBindings, so I don't think we should move them before we're ready to remove that. See the user story for details of the functions - I'm using that, so we can add more to this list as we spot them.
Priority: -- → P3
Depends on: 1539838
Keywords: meta
Summary: Investigate moving some functions from browser.js into the new address bar code once QuantumBar rewrite is complete → [meta] Investigate moving some functions from browser.js into the new address bar code once QuantumBar rewrite is complete
Blocks: 1551227
No longer depends on: quantumbar
Type: enhancement → task
See Also: → 1555414
Depends on: 1610475
Depends on: 1610533
No longer blocks: 1551227
Status: NEW → RESOLVED
Closed: 5 years ago
No longer depends on: 1539838, 1610475, 1610533
Resolution: --- → DUPLICATE
See Also: 1555414 →
You need to log in before you can comment on or make changes to this bug.