1517480 - [Content Blocking][MAC 10.14] Wrong text color in "report a problem" subpanel for "URL" and "What problems .."

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: black text.png

[Description:]

The text color for "URL" and "What problems did you have? (Optional)" is black, whereas is should be grey. (see attached Screenshot.)

This is an issue specific to OSX 10.14.2; it doesn't reproduced on 10.13.6;

[Environment:]
- 66.0a1 20190103094209
- 65.0b7 20181227144402

good - OSX 10.13.6
bad  - OSX 10.14.2

Comment 1

[Johann Hofmann [:johannh]]

This line:

https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/browser/themes/shared/controlcenter/panel.inc.css#356

should be using color: var(--panel-disabled-color); instead of graytext.

Comment 2

[Manish [:manishkk]]

:ntim

I think, this is a duplication of bug: 1515395
And this is OS dependent issue. That's why I was not able to see on my system.

Comment 4

[Tim Nguyen :ntim]

(In reply to Manish [:manishkk] from comment #2)

:ntim

I think, this is a duplication of bug: 1515395
And this is OS dependent issue. That's why I was not able to see on my system.

All platforms have the color set to GrayText, it just turns out that macOS sets GrayText to a black color, while other platforms use gray. Either way, comment 1 describes how to fix this.

Comment 5

[Tim Nguyen :ntim]

Thanks for pointing out the duplicates, I've duped the other bug to this one.

Comment 6

[Johann Hofmann [:johannh]]

Oh, I didn't realize, thanks for duping :)

Comment 7

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #1)

This line:

https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/browser/themes/shared/controlcenter/panel.inc.css#356

should be using color: var(--panel-disabled-color); instead of graytext.

As per bug 1520522, we shouldn't use var(--panel-disabled-color) here either.

Comment 8

[Dão Gottwald [:dao]]

Attachment: Bug 1517480 - Stop using graytext for labels in the "report a problem" subpanel. r=johannh

Comment 9

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9ae635a98ead94e9b74588a5efa4cae77692d7a

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/053747e3a369
Stop using graytext for labels in the "report a problem" subpanel. r=johannh

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/053747e3a369

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Looks like a pretty safe ride-along polish fix for RC2. Please nominate this for release approval if you agree. It grafts cleanly.

Comment 13

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.14 with Nightly 66.0a1 (2019-01-22) and I can confirm the fix.

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 9037294 [details]
Bug 1517480 - Stop using graytext for labels in the "report a problem" subpanel. r=johannh

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1474238

User impact if declined: see comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce:

List of other uplifts needed: -

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Simple UI change to avoid using graytext

String changes made/needed: -

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 9037294 [details]
Bug 1517480 - Stop using graytext for labels in the "report a problem" subpanel. r=johannh

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined:

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky):

String changes made/needed:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9037294 [details]
Bug 1517480 - Stop using graytext for labels in the "report a problem" subpanel. r=johannh

[Triage Comment]
Trivial UI polish fix. Approved for 65.0 RC2.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/2727c5c4c04e

Comment 18

[ovidiu boca[:Ovidiu]]

I verified on FF 65, Mac OS X 10.14 with the dark theme and I can confirm the fix.