Migrate pageInfo.dtd to Fluent
Categories
(Firefox :: General, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: jaws, Assigned: nautilus, Mentored)
References
(Depends on 1 open bug, Blocks 2 open bugs, Regressed 2 open bugs)
Details
Attachments
(1 file, 1 obsolete file)
pageInfo.dtd[1] should be migrated to Fluent. The new Fluent file should be created at browser\locales\en-US\browser\pageInfo.ftl A migration file should also be created at python\l10n\fluent_migrations The pageInfo.dtd includes a width and height that define the width and height of the subsequent dialog. These are setting the width and height attributes on the dialog. Due to the asynchronous nature of Fluent, these two values will need to set the style attribute instead. Please migrate the width and height values to a style attribute value as was done in [2]. [3] is an example migration script for converting from a width attribute to a style attribute. [1] https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/pageInfo.dtd [2] https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/locales/en-US/browser/preferences/applicationManager.ftl#7 [3] https://hg.mozilla.org/integration/autoland/diff/ab889ec68ba2/python/l10n/fluent_migrations/bug_1451992_preferences_colors.py#l1.32
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
...system. Updated the function "async _updateSiteDataInfo()" in browser/base/content/pageinfo/security.js to use Fluent localization strings migrated from browser/locales/en-US/chrome/browser/pageInfo.properties into pageInfo.ftl. This fixed an issue where the amount of data and cookies the website stored on my computer would always be listed as "Unknown" because the defualt Fluent strings loaded into the html would always overwrite the original set by security.js.
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cfb1a7fbbfa7 Migrating pageInfo to Fluent r=jaws,flod
Comment 4•5 years ago
|
||
Backed out changeset cfb1a7fbbfa7 (Bug 1517493) for bc failures in browser/base/content/test/static/browser_all_files_referenced.js
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229079648&repo=autoland&lineNumber=1353
12:27:46 INFO - indirectly whitelisted file: chrome://passwordmgr/content/recipes.json used from resource://gre/greprefs.js
12:27:46 INFO - indirectly whitelisted file: resource://formautofill/FormAutofillSync.jsm used from resource://services-sync/service.js
12:27:46 INFO - indirectly whitelisted file: chrome://global/locale/AccessFu.properties used from resource://gre/modules/accessibility/Utils.jsm
12:27:46 INFO - indirectly whitelisted file: resource://services-sync/bookmark_repair.js used from resource://services-sync/collection_repair.js
12:27:46 INFO - indirectly whitelisted file: resource://services-sync/doctor.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/stages/enginesync.js
12:27:46 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Traversal.jsm used from resource://gre/modules/accessibility/ContentControl.jsm
12:27:46 INFO - Buffered messages finished
12:27:46 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected 0
12:27:46 INFO - Stack trace:
12:27:46 INFO - chrome://mochikit/content/browser-test.js:test_is:1315
12:27:46 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:786
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
12:27:46 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
12:27:46 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
12:27:46 INFO - Not taking screenshot here: see the one that was previously logged
12:27:46 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/locale/pageInfo.properties -
12:27:46 INFO - Stack trace:
12:27:46 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
12:27:46 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:790
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
12:27:46 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
12:27:46 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
12:27:46 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
12:27:46 INFO - ignored unused whitelist entry: resource://app/blocklist.xml
12:27:46 INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
12:27:46 INFO - ignored unused whitelist entry: resource://gre/res/test.properties
12:27:46 INFO - missing file: resource:///modules/AboutDebuggingNewRegistration.jsm
12:27:46 INFO - missing file: resource://gre/components/nsAsyncShutdown.js
12:27:46 INFO - missing file: resource://gre/modules/commonjs/toolkit/loader.js
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2cfcb1247ec Backed out changeset cfb1a7fbbfa7 for bc failures in browser/base/content/test/static/browser_all_files_referenced.js
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d28d0498bd7b Migrating pageInfo to Fluent r=jaws,flod,Gijs
Comment 7•5 years ago
|
||
Backed out changeset d28d0498bd7b (Bug 1517493) for bc failures at browser_firstPartyIsolation_savaAs.js
Backout: https://hg.mozilla.org/integration/autoland/rev/05e4b6e62f776cd7266c62bf69c4280c1b868dfc
Push that started the failures:https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=d28d0498bd7b1cbacdb9077ac3ea456041dbe722&selectedJob=229607956
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229607956&repo=autoland&lineNumber=3544
Comment 8•5 years ago
|
||
There are also failures at: browser/base/content/test/pageinfo/browser_pageinfo_firstPartyIsolation.js
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229609492&repo=autoland&lineNumber=2086
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/03aece6cda47 migrated pageInfo.dtd and pageInfo.properties to pageInfo.ftl r=jaws,flod,Gijs
Comment 10•5 years ago
|
||
bugherder |
Comment 11•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•