1517494 - Create a new method listRoles2 (same as listRoles but paginated)

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[Hassan Ali (:hassan)]

We currently have the following methods:

listRoleIds - returns a paginated list of role IDs
listRoles - returns an array of objects of the form { roleId, scopes }

We want to add a third method `listRoles2` which returns the same data as `listRoles` but paginated.


For inspiration, you can have a look at the pull-request[1] that added `listRoleIds`. The implementation of the continuationToken (the way we handle paginaton) in `listRoles2` will be done similar to that pull-request.


[1] https://github.com/taskcluster/taskcluster-auth/pull/189

Comment 1

[Arshad Kazmi [:arshadkazmi42]]

I would like to work on this.
Assigning this to myself

Comment 2

[Arshad Kazmi [:arshadkazmi42]]

I am getting this message on `taskcluster-auth` repo

` This repository has been archived by the owner. It is now read-only.`

It will accept PR's ?

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Hi Arshad, sorry about that!  We moved to a monorepo yesterday, so the code is now in github.com/taskcluster/taskcluster.  Do you have a pull request ready to go?  If so, I'd suggest the following:

 * In your local copy, squash your changes down to a single commit
 * Use `git format-patch HEAD^..HEAD --stdout > /tmp/pr.patch` to output that commit 
 * clone https://github.com/taskcluster/taskcluster
 * In that repo, run `git apply --directory services/auth /tmp/pr.patch`

That should transplant the patch to the new repository, where you can then commit, push, and file a PR.

Comment 4

[Arshad Kazmi [:arshadkazmi42]]

Hi Dustin,
Thank you for the detailed steps.
My PR is not ready yet. I will do a fresh clone and create a PR.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Finished and deployed..

 $ curl -s https://auth.taskcluster.net/v1/roles2/?limit=2\&continuationToken=xGhP | head
{
  "continuationToken": "zvsO",
  "roles": [
    {
      "expandedScopes": [
        "assume:hook-id:project-focus/strings-import",
        "queue:create-task:aws-provisioner-v1/tutorial",
        "queue:route:[e-mail]-failed",
        "secrets:get:project/focus/github"
      ],

yay!