Closed Bug 1517519 Opened 11 months ago Closed 10 months ago

Migrate about:tabcrashed to Fluent

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: jaws, Assigned: berning5, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

about:tabcrashed loads the strings from browser/locales/en-US/chrome/browser/aboutTabCrashed.dtd

This should be converted to a Fluent file in browser/locales/en-US/browser/aboutTabCrashed.ftl

Please create a migration script in python/l10n/fluent_migrations.
Priority: -- → P3
Assignee: nobody → berning5
Status: NEW → ASSIGNED
Attachment #9037145 - Attachment description: Bug 1517519 - Migrated aboutTabCrashed dtd files to ftl files with migration script, r?jaws → Bug 1517519 - Migrated aboutTabCrashed dtd files to ftl files with migration script, r?flod
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b666f82d750
Migrated aboutTabCrashed dtd files to ftl files with migration script, r=jaws,flod

Backed out changeset 3b666f82d750 (bug 1517519) for Browser-chrome failures in browser/components/sessionstore/test/browser_background_tab_crash.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=223516663&repo=autoland

INFO - TEST-PASS | browser/base/content/test/tabcrashed/browser_autoSubmitRequest.js | Checkbox for autosubmission is not checked. - true == true -
07:38:32 INFO - Console message: [JavaScript Error: "failed"]
07:38:32 INFO - Buffered messages logged at 07:36:50
07:38:32 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<html><body>A%20regular,%20everyday,%20normal%20page." line: 0}]
07:38:32 INFO - TEST-PASS | browser/base/content/test/tabcrashed/browser_autoSubmitRequest.js | Autosubmission pref should have been set. - true == true -
07:38:32 INFO - Buffered messages finished
07:38:32 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabcrashed/browser_autoSubmitRequest.js | A promise chain failed to handle a rejection: (Unable to convert rejection reason to string.) - stack: (No stack available.)
07:38:32 INFO - Rejection date: Wed Jan 23 2019 07:36:49 GMT-0800 (Pacific Standard Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257
07:38:32 INFO - Stack trace:
07:38:32 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:257
07:38:32 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1133
07:38:32 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1099
07:38:32 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:997
07:38:32 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
07:38:32 INFO - Leaving test bound test_show_form
07:38:32 INFO - Entering test bound test_show_form
07:38:32 INFO - GECKO(947) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/6m/gys1r0kx3md1k58x6gsqv5p400000x/T/tmpIqlr_p.mozrunner/runtests_leaks_tab_pid956.log
07:38:32 INFO - GECKO(947) | ++DOCSHELL 0x1168e3000 == 1 [pid = 956] [id = {04d61f6e-5497-934c-8f9e-057404a79bb6}]
07:38:32 INFO - GECKO(947) | ++DOMWINDOW == 1 (0x1168c5000) [pid = 956] [serial = 1] [outer = 0x0]
07:38:32 INFO - GECKO(947) | ++DOMWINDOW == 2 (0x1168c7c00) [pid = 956] [serial = 2] [outer = 0x1168c5000]
07:38:32 INFO - GECKO(947) | ++DOMWINDOW == 3 (0x11e7d2800) [pid = 956] [serial = 3] [outer = 0x1168c5000]
07:38:32 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<html><body>A%20regular,%20everyday,%20normal%20page." line: 0}]
07:38:32 INFO - GECKO(947) | Et tu, Brute?
07:38:32 INFO - GECKO(947) | XPCOM_MEM_BLOAT_LOG: /var/folders/6m/gys1r0kx3md1k58x6gsqv5p400000x/T/tmpIqlr_p.mozrunner/runtests_leaks.log
07:38:32 INFO - GECKO(947) | Writing to log: /var/folders/6m/gys1r0kx3md1k58x6gsqv5p400000x/T/tmpIqlr_p.mozrunner/runtests_leaks_tab_pid956.log
07:38:32 INFO - GECKO(947) | ###!!! [Parent][MessageChannel] Error: (msgtype=0x1E0087,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv
07:38:32 INFO - GECKO(947) | ++DOCSHELL 0x111010800 == 7 [pid = 947] [id = {be4037a5-a310-c34d-b82a-7bab8706e699}]
07:38:32 INFO - GECKO(947) | ++DOMWINDOW == 15 (0x11655c000) [pid = 947] [serial = 15] [outer = 0x0]
07:38:32 INFO - GECKO(947) | ++DOMWINDOW == 16 (0x11a770c00) [pid = 947] [serial = 16] [outer = 0x11655c000]
07:38:32 INFO - Console message: [JavaScript Error: "remote browser crashed while on data:text/html,<html><body>A%20regular,%20everyday,%20normal%20page.
07:38:32 INFO - " {file: "chrome://mochikit/content/mochitest-e10s-utils.js" line: 8}]
07:38:32 INFO - e10s_init/<@chrome://mochikit/content/mochitest-e10s-utils.js:8:5
07:38:32 INFO - EventListener.handleEvente10s_init@chrome://mochikit/content/mochitest-e10s-utils.js:6:3
07:38:32 INFO - testInit@chrome://mochikit/content/browser-test.js:104:5
07:38:32 INFO - setTimeout handler
@chrome://mochikit/content/browser-test.js:22:1
07:38:32 INFO - loadChromeScripts@jar:file:///var/folders/6m/gys1r0kx3md1k58x6gsqv5p400000x/T/tmpIqlr_p.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:15:3
07:38:32 INFO - loadMochitest@jar:file:///var/folders/6m/gys1r0kx3md1k58x6gsqv5p400000x/T/tmpIqlr_p.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:111:3
07:38:32 INFO - @tests/mochitest/runtests.py:1733:1
07:38:32 INFO - @tests/mochitest/runtests.py:1712:2
07:38:32 INFO - evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:130:13

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1c227ac918eb1ab0b702d4424603faeb836f2b1c&selectedJob=223517409

Backout:
https://hg.mozilla.org/integration/autoland/rev/bdf9d6dfa2f6fbe1c69fb9715b9368c7c8ede8c0

Flags: needinfo?(berning5)

The issue appears to be with a semi-colon on a line in the aboutTabCrashed.xhtml

This line:
<textarea id="comments" data-l10n-id="crashed-comment-placeholder;" rows="4"></textarea>

There should not be a semi colon on: crashed-comment-placeholder

I fixed the issue (by removing the semicolon) and submitted my commit for review.

Though, after looking at the page now, it appears as though the semi colon is still present.

Perhaps I did not submit correctly when the review was reopened.

Flags: needinfo?(berning5)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd9435f9df3f
Migrated aboutTabCrashed dtd files to ftl files with migration script, r=jaws,flod
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Depends on: 1525176
You need to log in before you can comment on or make changes to this bug.