Closed
Bug 1517529
Opened 6 years ago
Closed 6 years ago
Migrate safeMode.dtd to Fluent
Categories
(Firefox :: General, enhancement, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: jaws, Assigned: nickcowles9575, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
safeMode.dtd[1] should be migrated to Fluent. The new Fluent file should be created at browser\locales\en-US\browser\safeMode.ftl
A migration file should also be created at python\l10n\fluent_migrations
The pageInfo.dtd includes a maxWidth that define the width of the subsequent dialog. This sets the maxwidth attribute on the dialog. Due to the asynchronous nature of Fluent, this value will need to be set on the style attribute instead. Please migrate the maxWidth value to a style attribute value as was done in [2]. [3] is an example migration script for converting from a width attribute to a style attribute.
[1] https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/safeMode.dtd
[2] https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/browser/locales/en-US/browser/preferences/applicationManager.ftl#7
[3] https://hg.mozilla.org/integration/autoland/diff/ab889ec68ba2/python/l10n/fluent_migrations/bug_1451992_preferences_colors.py#l1.32
Updated•6 years ago
|
Priority: -- → P3
Reporter | ||
Comment 1•6 years ago
|
||
In the second paragraph of the above comment, I meant to refer to safeMode.dtd, not pageInfo.dtd.
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → nickcowles9575
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Updated•6 years ago
|
Attachment #9037595 -
Attachment is obsolete: true
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/585816362855
Migrate safeMode dialog to Fluent for localization, r=Gijs,flod
Comment 5•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•