1517569 - Lightning - Can't edit start or end times of an event

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Jean Lafontaine]

Attachment: Edition of the just created event.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

With Thunderbird 60.2.1 with xul-ext-lightning from Mint 19.1 or Solydx EE both OS are configure in french but calendar is in english only.

Just trying to add a new event in my calendars (local calendar or google calendar) 


Actual results:

To reproduce the problem just add a new event and try to modify the start hour. when you press tab to change field and go in end hour field, the start hour reset to 00h00 and vice versa.

If you just create a new event and don't edit the hour fields, it will be created correctly but as soon as you enter the hour field and try to modify something it will reset the hour to 00h00

Its impossible to had a new event with the start hour and end hour edited.


Expected results:

It should be possible to edit the hour field at creation or when a modification is necessary on the event.

Comment 1

[Jean Lafontaine]

Attachment: Edition of the just created event - no email.png

Comment 2

[Jean Lafontaine]

Comment on attachment 9034243 [details]
Edition of the just created event.png

wrong image

Comment 3

[WaltS48 [:walts48]]

I can't reproduce this using Thunderbird 60.2.1 with Lightning 6.2.2.1 provided by Ubuntu running on Linux Mint 19. Both are English versions.

Comment 4

[Jean Lafontaine]

Thanks for your verification, it made me think that something with the local (system-wide)was not OK. I then have checked the language region setting in cinnamon parameters.  The region system-wide was not set. So i apply it system-wide (Appliquer à tout le système).

Now I'm able to edit the hour field in the lightning extension.

It is strange because that bug only appears recently with a new version of Thunderbird on SolydX. Then i did a fresh install of Mint and i had the same issue.

Do i change something to resolve or if this need more investigation?

Thanks!

Comment 5

[Jean Lafontaine]

Attachment: language- region setting.png

Post solution setting on mint 19.1

Comment 6

[Jean Lafontaine]

Sorry,

I did not checked it properly and the problem is still present.

Comment 7

[Jean Lafontaine]

I made more verification. The only condition where lightning is working properly is when the language is set to English (AM-PM). I did not check in other language.

By the way, I do not plan to use English so I'm still looking for a solution.

Thanks!

Comment 8

[Jean Lafontaine]

Hi,

Here is a temporary solution that i have put in place to be able to use lightning as my calendar application.

I have simply create a launcher with that command:

bash -c 'export LC_TIME=en_CA.UTF-8 ; thunderbird %u'

en_CA locale has the right format aaaa-mm-dd (like in French) and the hour is now showing in AM-PM format. Lightning is functional but not fr_CA compliant.

If someone has a better solution please don't hesitate to post.

Thanks!

Comment 9

[[:MakeMyDay]]

Please check with the upcoming TB66 beta [1] (available in the next couple of days) whether the issue is still present. If doing so, please use either a new profile or make sure to backup your TB profile before using it with the beta, since profile downgrading (from beta to esr after completing the test) is not supported and may cause problems.

[1] https://www.thunderbird.net/de/channel/

Comment 10

[Jean Lafontaine]

Hi,

Just tried TB66b and i still have the same problem, the time reset to 00:00 when exiting the start time field.

Its only possible to create an event by doing a clik and pull in the day at the hours that you want.

Thanks!

Comment 11

[[:MakeMyDay]]

Does the issue also reproduce for you if you have all addons but Lightning disabled in addons-manager and restarted TB?

Comment 12

[[:MakeMyDay]]

Can you please also provide the last section "Internationalization & Localization" from the TB troubleshooting information (menu->help->troubleshooting information)?

Comment 13

[Jean Lafontaine]

All addons are disabled in TB

Langue et internationalisation
Paramètres d’application
Langues demandées ["fr"]
Langues disponibles ["fr"]
Langues de l’application ["fr","en-US"]
Préférences régionales ["fr-CA"]
Langue par défaut "fr"
Système d’exploitation
Langues du système ["fr-CA"]
Préférences régionales ["fr-CA"]

Comment 14

[Roger Gravel]

Hi,
I have the same problem than Jean Lafontaine.
And I also see that we are not alone to experiment this bug.

Comment 15

[Roger Gravel]

(In reply to [:MakeMyDay] from comment #11)

Does the issue also reproduce for you if you have all addons but Lightning disabled in addons-manager and restarted TB?

All addons are disabled in TB

Langue et internationalisation
Paramètres d’application
Langues demandées ["fr-CA","en-US"]
Langues disponibles ["fr"]
Langues de l’application ["fr","und"]
Préférences régionales ["fr-CA"]
Langue par défaut "und"
Système d’exploitation
Langues du système ["fr-CA"]
Préférences régionales ["fr-CA"]

Thank you.

Comment 16

[[:MakeMyDay]]

Can you please check again with the new TB66 b3 available at [1] again and report whether the issue still exists?

[1] https://www.thunderbird.net/channel/

Comment 17

[Roger Gravel]

(In reply to [:MakeMyDay] from comment #16)

Can you please check again with the new TB66 b3 available at [1] again and report whether the issue still exists?

[1] https://www.thunderbird.net/channel/

No, I cannot check with a beta version ;
but I am told that 60.6 should be out in 2 weeks and correct the BUG.

And I can wait.

Thank you

Comment 18

[[:MakeMyDay]]

This is not guaranteed until you verified that it works for you, since the reported issues is not present/reporducable here and can only be found and fixed with the help of people who are seeing the issue.

There are different datetime issues around and we fixed an issue different from the AM/PM issue, but we would like to know whether the AM/PM issue is fixed as a by-product. So, please reconsider and keep in mind this is a community project.

Comment 19

[Jean Lafontaine]

Hi!

Here my observations with the new TB66 b3. Maybe it was similar on the current release, i did not check in details.

When i create a new event by double clicking in the calendar, the edition windows opened with the right start time and with the end time one hour later (9:00 to 10:00) that a normal behaviour.

If i try to modifies the start time to begin my event at 9:15 (i did verified that i click on the right number 09 for hours and :15 for minutes). When i exit the start field, the start time change from 9:15 to 15:00. And the end time is automatically change to 16:00 to match the initial duration of that event.

If the modified start time is 9:20 i got 20:00 when leaving the start field edition.

If i try to edit the end hour field i always get an alert message saying that the end date is prior to the start date but both date are the same with start time an hour before the end time. So its not a right validation.

I can save the event with no problem (so the previous validation message was wrong?)

When trying to edit for a second time the save event, i can modify the start time (21:00) and without exiting the field, i then press the save button and the event is save but it shift the start time to 00:00 and saved the event at that time not the edited time of 21:00.

If i edit the start time to 21:00 again and try to exit the start field to edit the end time, The start time reset to 00:00 every time with no possibilities of editing to whatever you choose.

Then i tried to edit with the mouse by drag and drop or extend the time by pulling the mouse, this is working OK. Then again i tried to edit the event by double clicking. And the i can edit the event again and save it but with the same limitation (the minute become the hour etc..)

So by dragging there is a reset somewhere in the code that permit do come back to the first editing problem.

I home that those information will help you debug that code.

Thanks for your help!

Comment 20

[Jean Lafontaine]

Me again,

Just want to rectified the 00:00 reset is minute > hour problem, what i said in the previous post is not exact. You can always edit the time but the minutes always become the hours so if you choose 9:00 it will always reset the hour to 00:00.

Sorry for that!

Comment 21

[Roger Gravel]

(In reply to Jean Lafontaine from comment #20)

Me again,

Just want to rectified the 00:00 reset is minute > hour problem, what i said in the previous post is not exact. You can always edit the time but the minutes always become the hours so if you choose 9:00 it will always reset the hour to 00:00.

Sorry for that!
Jean,

I have the same issue.

Do you think it is a bright idea to try a beta version of TB ?

I have to add that as a retired programmer myself,
I have never installed a product that was not tried and foolproof.

Regards

Comment 22

[Jean Lafontaine]

(In reply to Roger Gravel from comment #21)

(In reply to Jean Lafontaine from comment #20)

Jean,

I have the same issue.

Do you think it is a bright idea to try a beta version of TB ?

I have to add that as a retired programmer myself,
I have never installed a product that was not tried and foolproof.

Regards

Bonjour Roger,

I use another computer to test the beta to be sure that there will be no issues. You can also use a virtualbox installation to test those things. But i understand your concerns. I often face problem with testing software but when its not on my main computer, i can live with it.

Jean

Comment 23

[[:MakeMyDay]]

It's safe to install the beta next to the esr version on the same machine. The beta starts with a fresh profile, which is enough to check the issue (just close the poping up account wizard).

Comment 24

[[:MakeMyDay]]

Thanks you Jean for the helpful description. I will come back to this if I need further observations or checks from your end.

Comment 25

[[:MakeMyDay]]

Attachment: IgnoreExtraSpacesWhileDetectingTimeSeparators-V1.diff

Ok, I'm able to reproduce the behaviour. The cuprit is that the "h" spearator in the screenshot is enclosed by spaces. When putting in a time using this pattern makes the time parser choking.

I spare an uplift request for now, since I cannot verify locally, whether the reported issue vanished with this fix.

Comment 26

[[:MakeMyDay]]

Attachment: {e2fda1a4-762b-4020-b5ad-a41df1933103}.xpi for TB66b3

Jean, can you check with the attached xpi (for TB66 b3) whether the issue is resolved for you with this patch? You can simply overinstall this by installing from file using the TB addons manager and restart TB afterwards.

Comment 27

[Jean Lafontaine]

(In reply to [:MakeMyDay] from comment #26)

Created attachment 9051565 [details]
{e2fda1a4-762b-4020-b5ad-a41df1933103}.xpi for TB66b3

Jean, can you check with the attached xpi (for TB66 b3) whether the issue is resolved for you with this patch? You can simply overinstall this by installing from file using the TB addons manager and restart TB afterwards.

Hi, just back from skiing.

I think, you just resolved the issue with your patch on TB 66.0b3.

Just let me know when and on which non beta release it will be available.

Thanks!

Jean

Comment 28

[[:MakeMyDay]]

So you are confirming it works for you? You will notice the ESR version once the patch gets uplifted.

Comment 29

[[:MakeMyDay]]

Comment on attachment 9051562 [details] [diff] [review]
IgnoreExtraSpacesWhileDetectingTimeSeparators-V1.diff

The beta approval may be obsolete if the patch lands before the merges tommorrow.

Comment 30

[[:MakeMyDay]]

Attachment: IgnoreSpacesAroundTimeSeparators-ESR60-V1.diff

Comment 31

[Jean Lafontaine]

(In reply to [:MakeMyDay] from comment #28)

So you are confirming it works for you? You will notice the ESR version once the patch gets uplifted.

Yes i do confirm that its working for me.

Thanks!

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fdbbe7d76632
Ignore spacing around time separators when parsing times in timepicker. r=philipp

Comment 33

[Jorg K (CEST = GMT+2)]

Backout:
https://hg.mozilla.org/comm-central/rev/58c62d0c0ebc0f750f45e600e749d6bf1ca9201d
Backed out changeset fdbbe7d76632 (bug 1517569) for test failures in testTimezones.js. a=backout DONTBUILD

Sorry, I had to back this out for eight test failures in testTimezones.js:
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones3_checkStJohns
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones4_checkCaracas
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones5_checkPhoenix
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones6_checkLosAngeles
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones7_checkBuenosAires
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones8_checkParis
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones9_checkKathmandu
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1553942585/build/tests/mozmill/testTimezones.js | testTimezones.js::testTimezones10_checkAdelaide

The test passes locally on Windows if the locale is set to en-GB, it fails with locale en-US.

EDIT:
Push was https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=9ec42b993238cc77d539150cfa3a934be3be6053&selectedJob=237031546
Failed on all platforms.

Comment 34

[Geoff Lankow (:darktrojan)]

Attachment: 1517569-parse-time-1.diff

With the previous patch, the regular expression was capturing the " pm" in "2:00 pm" as a separator instead of as the am/pm marker … so it assumed there was no marker and the input was 2 am.

With this patch I explicitly look for a single character of white-space around the separators.

Comment 35

[Geoff Lankow (:darktrojan)]

I might fix up the typo in the commit message too … not sure what a spearator is but it sounds nasty.

Comment 36

[Geoff Lankow (:darktrojan)]

Note comment 35 if you're checking this in.

Comment 37

[Geoff Lankow (:darktrojan)]

Let's give this bug a spell on nightly/beta before we push it to ESR.

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/92831637a3fa
Ignore spacing around time separators when parsing times in timepicker. r=philipp

Comment 39

[Jorg K (CEST = GMT+2)]

TB 68 beta / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/15ed6f4a09a76a6fad4ae918f76eee842d517e6f

Comment 40

[Jorg K (CEST = GMT+2)]

TB 60.8 ESR / Cal 6.2.8:
https://hg.mozilla.org/releases/comm-esr60/rev/8e1ce8a186e1e6736115177707ff3ecc51161d3a

Need 6.2.8.