Closed Bug 1517621 Opened Last year Closed 11 months ago
Running tryselect python-tests causes try
_task _config .json to be added to the local repo
47 bytes, text/x-phabricator-request
|Details | Review|
STR: [~/dev/mozilla-central](5826b23)$ hg status [~/dev/mozilla-central](5826b23)$ ./mach python-test test_again.py ... 0:08.89 Return code from mach python-test: 0 [~/dev/mozilla-central](5826b23)$ hg status ! try_task_config.json This is happening because while we do Mock out certain VCS operations , we don't mock out "add_remove_files" . Instead of manually mocking out individual attributes, we should just mock out the entire "vcs" object using a MagicMock.  https://searchfox.org/mozilla-central/source/tools/tryselect/test/conftest.py#22  https://searchfox.org/mozilla-central/source/tools/tryselect/push.py#130
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/165704210c3f [tryselect] Mock out entire vcs object in python tests, r=jmaher
You need to log in before you can comment on or make changes to this bug.