Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

No description provided.
Posted patch PatchSplinter Review
Note that

+using JSConstDoubleSpec = JSConstScalarSpec<double>;
+using JSConstIntegerSpec = JSConstScalarSpec<int32_t>;

cannot be moved out of jsapi.h because there are functions in that file that use those types in their signatures, and it's not possible to forward-declare |using|s.  (And those functions don't quite seem to belong in PropertySpec.h.)

Codegen.py that creates bindings .cpp/.h doesn't need to add an #include for this, because DOMJSClass.h does so itself and already needs JSPropertySpec/JSFunctionSpec itself.  It's possible this could be even further minimized, but at least this deserves followup treatment, not further work in this exact patch.
Attachment #9034296 - Flags: review?(arai.unmht)
Comment on attachment 9034296 [details] [diff] [review]
Patch

Review of attachment 9034296 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Iteration.cpp
@@ +27,5 @@
>  #include "ds/Sort.h"
>  #include "gc/FreeOp.h"
>  #include "gc/Marking.h"
> +#include "js/PropertySpec.h"
> +#include "js/PropertySpec.h"

remove one of them
Attachment #9034296 - Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf00fd0f080c
Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header.  r=arai
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6628922b7be
Followup fix for the sm-rust job, r=bustage, r=me as trivial
https://hg.mozilla.org/mozilla-central/rev/cf00fd0f080c
https://hg.mozilla.org/mozilla-central/rev/e6628922b7be
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

This got backed out, so technically it's not actually fixed. (Possibly I gunked up the backout messages enough that no backout comment got added here.) Just relanded, tho, and unless that gets backed out it ain't worth a reopen.

Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77a8b1716321
Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header.  r=arai
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62605bf1938a
Followup fix for the sm-rust job, r=bustage, r=me as trivial
Depends on: 1518382
https://hg.mozilla.org/projects/cedar/rev/77a8b17163210f7d4bba7e800c2fcb55b0690a24
Bug 1517624 - Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header.  r=arai

https://hg.mozilla.org/projects/cedar/rev/62605bf1938a7b756114136114321ea97ac27770
Bug 1517624 - Followup fix for the sm-rust job, r=bustage, r=me as trivial

This undid the patch for bug 1516567, see bug 1518812.

You need to log in before you can comment on or make changes to this bug.