Closed
Bug 1517624
Opened 5 years ago
Closed 5 years ago
Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
Attachments
(1 file)
44.46 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
Note that +using JSConstDoubleSpec = JSConstScalarSpec<double>; +using JSConstIntegerSpec = JSConstScalarSpec<int32_t>; cannot be moved out of jsapi.h because there are functions in that file that use those types in their signatures, and it's not possible to forward-declare |using|s. (And those functions don't quite seem to belong in PropertySpec.h.) Codegen.py that creates bindings .cpp/.h doesn't need to add an #include for this, because DOMJSClass.h does so itself and already needs JSPropertySpec/JSFunctionSpec itself. It's possible this could be even further minimized, but at least this deserves followup treatment, not further work in this exact patch.
Attachment #9034296 -
Flags: review?(arai.unmht)
Comment 2•5 years ago
|
||
Comment on attachment 9034296 [details] [diff] [review] Patch Review of attachment 9034296 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/Iteration.cpp @@ +27,5 @@ > #include "ds/Sort.h" > #include "gc/FreeOp.h" > #include "gc/Marking.h" > +#include "js/PropertySpec.h" > +#include "js/PropertySpec.h" remove one of them
Attachment #9034296 -
Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/cf00fd0f080c Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header. r=arai
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6628922b7be Followup fix for the sm-rust job, r=bustage, r=me as trivial
Comment 5•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf00fd0f080c https://hg.mozilla.org/mozilla-central/rev/e6628922b7be
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee | ||
Comment 6•5 years ago
|
||
This got backed out, so technically it's not actually fixed. (Possibly I gunked up the backout messages enough that no backout comment got added here.) Just relanded, tho, and unless that gets backed out it ain't worth a reopen.
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/77a8b1716321 Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header. r=arai
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/62605bf1938a Followup fix for the sm-rust job, r=bustage, r=me as trivial
Comment 9•5 years ago
|
||
bugherder |
Comment 10•5 years ago
|
||
https://hg.mozilla.org/projects/cedar/rev/77a8b17163210f7d4bba7e800c2fcb55b0690a24 Bug 1517624 - Move JSPropertySpec and JSFunctionSpec definitions into a new js/public/PropertySpec.h header. r=arai https://hg.mozilla.org/projects/cedar/rev/62605bf1938a7b756114136114321ea97ac27770 Bug 1517624 - Followup fix for the sm-rust job, r=bustage, r=me as trivial
Comment 11•5 years ago
|
||
This undid the patch for bug 1516567, see bug 1518812.
You need to log in
before you can comment on or make changes to this bug.
Description
•