[wpt-sync] Sync PR 14706 - Make background-size: cover and contain really cover

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P4
normal
RESOLVED FIXED
7 months ago
5 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 14706 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14706
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:
>  Make background-size: cover and contain really cover
>  
>  With background-repeat: no-repeat and background-size: cover, the
>  computations for dest rect for the no-repeat case use the tile size
>  to set the dest rect. This prevents tiled drawing from painting more
>  than one tile. But the background-size computations for cover and
>  contain use an unsnapped position area to set the tile size, which
>  produces an unsnapped tile size. This unsnapped tile size, when set as
>  the dest rect for painting results in a tile that doesn't fill the
>  background as one would expect for cover or contain.
>  
>  This patch switches to always computing the cover and contain tile
>  sizes using a snapped position area to give a snapped dest rect.
>  
>  R: fs@opera.com
>  Bug: 785171
>  Change-Id: I38343ac09d689e9d1360e7043b2ef49adeadb983
>  Reviewed-on: https://chromium-review.googlesource.com/1394014
>  WPT-Export-Revision: d91017877dcc189ed2ea8c556dc70800300d88d5
Component: web-platform-tests → Layout
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/008eb2c66b1c
[wpt PR 14706] - Make background-size: cover and contain really cover, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6966be74e5b1
[wpt PR 14706] - Make background-size: cover and contain really cover, a=testonly
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.