Closed
Bug 1517632
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 14706 - Make background-size: cover and contain really cover
Categories
(Core :: Layout, enhancement, P4)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14706 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14706 Details from upstream follow. Stephen Chenney <schenney@chromium.org> wrote: > Make background-size: cover and contain really cover > > With background-repeat: no-repeat and background-size: cover, the > computations for dest rect for the no-repeat case use the tile size > to set the dest rect. This prevents tiled drawing from painting more > than one tile. But the background-size computations for cover and > contain use an unsnapped position area to set the tile size, which > produces an unsnapped tile size. This unsnapped tile size, when set as > the dest rect for painting results in a tile that doesn't fill the > background as one would expect for cover or contain. > > This patch switches to always computing the cover and contain tile > sizes using a snapped position area to give a snapped dest rect. > > R: fs@opera.com > Bug: 785171 > Change-Id: I38343ac09d689e9d1360e7043b2ef49adeadb983 > Reviewed-on: https://chromium-review.googlesource.com/1394014 > WPT-Export-Revision: d91017877dcc189ed2ea8c556dc70800300d88d5
Assignee | ||
Updated•5 years ago
|
Component: web-platform-tests → Layout
Product: Testing → Core
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffcd01e3ed6d5e10d6c5cc9e59a9bb69b9385299
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=125684b6053a1feafa38be8e4b04fa0b97aeb767
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1138624b16e2c26636c69e33504bb0570f5243a2
Assignee | ||
Comment 4•5 years ago
|
||
Ran 1 tests PASS : 1
Assignee | ||
Comment 5•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=046fae8893f472cb04a20c43322f2a911a922305
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/008eb2c66b1c [wpt PR 14706] - Make background-size: cover and contain really cover, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/6966be74e5b1 [wpt PR 14706] - Make background-size: cover and contain really cover, a=testonly
Comment 8•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•