Closed Bug 1517641 Opened 5 years ago Closed 4 years ago

Create new list categories in Gecko for Focus's new blocklists

Categories

(GeckoView :: General, enhancement, P1)

Product:
GeckoView
Component:
General
Platform:
All
Android
Type:
enhancement

Tracking

(geckoview64 wontfix, geckoview65+ fixed, geckoview66+ fixed, firefox64 wontfix, firefox65 wontfix, firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
geckoview64 --- wontfix
geckoview65 + fixed
geckoview66 + fixed
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: cpeterson, Assigned: esawin)

References

Details

(Whiteboard: [geckoview:fenix:p1])

Attachments

(2 files)

Bug 1517641 - [1.0] Add experimental ad-blocking category to the Tracking Protection API.
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-geckoview65+
Details | Review
Bug 1517641 - [2.0] Rename blocklist names to use a three-part naming scheme.
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-geckoview65+
Details | Review 
These new categories will be used for Focus 9.0's ad blocking experiment. Colin will be creating the new blocklists and categories as described in this product doc:

https://docs.google.com/document/d/1uIoXhZsque8zCNj0UqXVRuR4pbwDTVhfGiIzQxIXi4U/edit

I've decided not to block this experiment on bug 1499214, since the volume and complexity of the changes for the Content Blocking API would make it difficult and risky to uplift.

Whiteboard: [geckoview:fenix:p1]

@dimi, you've raised a good point about the blocklist names not including -track- causing problems with the mapping in TablesToResponse.
I see that TablesToReponse is still used in nsUrlClassifierDBService, will this affect our tracker reporting via onSecurityChange in https://searchfox.org/mozilla-central/source/mobile/android/modules/geckoview/GeckoViewTrackingProtection.jsm?

Flags: needinfo?(dlee)

(In reply to Eugen Sawin [:esawin] from comment #4)

@dimi, you've raised a good point about the blocklist names not including -track- causing problems with the mapping in TablesToResponse.
I see that TablesToReponse is still used in nsUrlClassifierDBService, will this affect our tracker reporting via onSecurityChange in https://searchfox.org/mozilla-central/source/mobile/android/modules/geckoview/GeckoViewTrackingProtection.jsm?

No, that is used by the legacy code while we used to use the classify API(used by SafeBrowsing) to classify tracking resource.
Now we don't use that for tracking protection.

The reason I was suggesting '-track-' is I thought those tables are for trackers, so we can keep using the naming rule.
As you said, the tables are not only for trackers, then I think it is fine to use what you are using now.

Flags: needinfo?(dlee)
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f57051371bf0
[1.0] Add experimental ad-blocking category to the Tracking Protection API. r=snorp,geckoview-reviewers,dimi

Backed out changeset f57051371bf0 (Bug 1517641) for apilint bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f57051371bf06a8755aa69a5403b2011d63e40f1&selectedJob=222580589

Backout link: https://hg.mozilla.org/integration/autoland/rev/f3a929ceb8c151e7493d1bbce71acf9c98d63174

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222580589&repo=autoland&lineNumber=2938

[task 2019-01-17T23:16:54.520Z] 23:16:54 INFO - make[2]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2019-01-17T23:16:54.536Z] 23:16:54 INFO - /bin/make -j16 --output-sync=line -C /builds/worker/workspace/build/src/obj-firefox automation/build
[task 2019-01-17T23:16:54.551Z] 23:16:54 INFO - make[1]: Entering directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2019-01-17T23:16:54.551Z] 23:16:54 INFO - Automation steps completed.
[task 2019-01-17T23:16:54.551Z] 23:16:54 INFO - make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2019-01-17T23:16:54.571Z] 23:16:54 INFO - 0 compiler warnings present.
[task 2019-01-17T23:16:54.586Z] 23:16:54 INFO - Overall system resources - Wall time: 101s; CPU: 0%; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2019-01-17T23:16:54.595Z] 23:16:54 INFO - To view resource usage of the build, run |mach resource-usage|.
[task 2019-01-17T23:16:54.596Z] 23:16:54 INFO - Your build was successful!
[task 2019-01-17T23:16:54.596Z] 23:16:54 INFO - For more information on what to do now, see https://developer.mozilla.org/docs/Developer_Guide/So_You_Just_Built_Firefox
[task 2019-01-17T23:16:54.611Z] 23:16:54 INFO - Return code: 0
[task 2019-01-17T23:16:54.612Z] 23:16:54 INFO - Setting properties found in: /builds/worker/workspace/build/src/obj-firefox/dist/bin/application.ini
[task 2019-01-17T23:16:54.612Z] 23:16:54 INFO - Verifying buildid from application.ini matches buildid from automation
[task 2019-01-17T23:16:54.612Z] 23:16:54 INFO - Getting output from command: ['/usr/bin/python2.7', '/builds/worker/workspace/build/src/mach', 'python', '/builds/worker/workspace/build/src/config/printconfigsetting.py', '/builds/worker/workspace/build/src/obj-firefox/dist/bin/application.ini', 'App', 'BuildID'] in /builds/worker/workspace/build/src/obj-firefox
[task 2019-01-17T23:16:54.612Z] 23:16:54 INFO - Copy/paste: /usr/bin/python2.7 /builds/worker/workspace/build/src/mach python /builds/worker/workspace/build/src/config/printconfigsetting.py /builds/worker/workspace/build/src/obj-firefox/dist/bin/application.ini App BuildID
[task 2019-01-17T23:16:54.614Z] 23:16:54 DEBUG - Temporary files: tmpfile_stdout and tmpfile_stderr
[task 2019-01-17T23:16:54.897Z] 23:16:54 INFO - Reading from file tmpfile_stdout
[task 2019-01-17T23:16:54.897Z] 23:16:54 INFO - Output received:
[task 2019-01-17T23:16:54.897Z] 23:16:54 INFO - 20190117230846
[task 2019-01-17T23:16:54.897Z] 23:16:54 DEBUG - rmtree: tmpfile_stderr
[task 2019-01-17T23:16:54.897Z] 23:16:54 DEBUG - retry: Calling remove with args: ('tmpfile_stderr',), kwargs: {}, attempt #1
[task 2019-01-17T23:16:54.897Z] 23:16:54 DEBUG - rmtree: tmpfile_stdout
[task 2019-01-17T23:16:54.897Z] 23:16:54 DEBUG - retry: Calling remove with args: ('tmpfile_stdout',), kwargs: {}, attempt #1
[task 2019-01-17T23:16:54.897Z] 23:16:54 DEBUG - Return code: 0
[task 2019-01-17T23:16:54.897Z] 23:16:54 INFO - buildid from application.ini: "20190117230846". buildid from automation properties: "20190117230846"
[task 2019-01-17T23:16:54.897Z] 23:16:54 INFO - buildids match.
[task 2019-01-17T23:16:54.897Z] 23:16:54 INFO - Collecting build metrics
[task 2019-01-17T23:16:54.898Z] 23:16:54 INFO - Getting output from command: ['/usr/bin/python2.7', 'mach', 'warnings-list'] in /builds/worker/workspace/build/src
[task 2019-01-17T23:16:54.898Z] 23:16:54 INFO - Copy/paste: /usr/bin/python2.7 mach warnings-list
[task 2019-01-17T23:16:54.900Z] 23:16:54 DEBUG - Temporary files: tmpfile_stdout and tmpfile_stderr
[task 2019-01-17T23:16:55.120Z] 23:16:55 DEBUG - rmtree: tmpfile_stderr
[task 2019-01-17T23:16:55.120Z] 23:16:55 DEBUG - retry: Calling remove with args: ('tmpfile_stderr',), kwargs: {}, attempt #1
[task 2019-01-17T23:16:55.120Z] 23:16:55 DEBUG - rmtree: tmpfile_stdout
[task 2019-01-17T23:16:55.120Z] 23:16:55 DEBUG - retry: Calling remove with args: ('tmpfile_stdout',), kwargs: {}, attempt #1
[task 2019-01-17T23:16:55.120Z] 23:16:55 DEBUG - Return code: 0
[task 2019-01-17T23:16:55.122Z] 23:16:55 INFO - /builds/worker/workspace/build/src/obj-firefox/sccache-stats.json does not exist; not loading sccache stats
[task 2019-01-17T23:16:55.122Z] 23:16:55 INFO - PERFHERDER_DATA: {"framework": {"name": "build_metrics"}, "suites": [{"subtests": [{"name": "configure", "value": 9.217543125152588}, {"name": "pre-export", "value": 0.22220802307128906}, {"name": "export", "value": 86.44580602645874}, {"name": "misc", "value": 1.3838510513305664}, {"name": "libs", "value": 3.751317024230957}, {"name": "tools", "value": 0.07734513282775879}], "extraOptions": ["taskcluster-c5.4xlarge", "android-api-lint"], "name": "build times", "value": 101.0560610294342}]}
[task 2019-01-17T23:16:55.122Z] 23:16:55 INFO - Running command: ['/usr/bin/python2.7', 'mach', '--log-no-times', 'android', 'api-lint'] in /builds/worker/workspace/build/src
[task 2019-01-17T23:16:55.122Z] 23:16:55 INFO - Copy/paste: /usr/bin/python2.7 mach --log-no-times android api-lint
[task 2019-01-17T23:16:55.122Z] 23:16:55 INFO - Using env: (same as previous command)
[task 2019-01-17T23:16:55.333Z] 23:16:55 INFO - /builds/worker/workspace/build/src/android-gradle-dependencies/gradle-dist/bin/gradle --console=plain geckoview:apiLintWithGeckoBinariesDebug
[task 2019-01-17T23:16:55.342Z] 23:16:55 INFO - Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
[task 2019-01-17T23:16:55.663Z] 23:16:55 INFO - To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.10.2/userguide/gradle_daemon.html.
[task 2019-01-17T23:16:56.262Z] 23:16:56 INFO - Daemon will be stopped at the end of the build stopping after processing
[task 2019-01-17T23:16:57.362Z] 23:16:57 INFO - Parallel execution is an incubating feature.
[task 2019-01-17T23:17:01.464Z] 23:17:01 INFO - > Task :geckoview:preBuild UP-TO-DATE
[task 2019-01-17T23:17:01.464Z] 23:17:01 INFO - > Task :geckoview:preWithGeckoBinariesDebugBuild UP-TO-DATE
[task 2019-01-17T23:17:01.562Z] 23:17:01 INFO - > Task :geckoview:compileWithGeckoBinariesDebugAidl UP-TO-DATE
[task 2019-01-17T23:17:01.562Z] 23:17:01 INFO - > Task :geckoview:compileWithGeckoBinariesDebugRenderscript UP-TO-DATE
[task 2019-01-17T23:17:01.562Z] 23:17:01 INFO - > Task :geckoview:checkWithGeckoBinariesDebugManifest UP-TO-DATE
[task 2019-01-17T23:17:01.563Z] 23:17:01 INFO - > Task :geckoview:generateWithGeckoBinariesDebugBuildConfig UP-TO-DATE
[task 2019-01-17T23:17:01.563Z] 23:17:01 INFO - > Task :geckoview:generateWithGeckoBinariesDebugResValues UP-TO-DATE
[task 2019-01-17T23:17:01.563Z] 23:17:01 INFO - > Task :geckoview:generateWithGeckoBinariesDebugResources UP-TO-DATE
[task 2019-01-17T23:17:01.563Z] 23:17:01 INFO - > Task :geckoview:packageWithGeckoBinariesDebugResources UP-TO-DATE
[task 2019-01-17T23:17:01.563Z] 23:17:01 INFO - > Task :geckoview:platformAttrExtractor UP-TO-DATE
[task 2019-01-17T23:17:01.563Z] 23:17:01 INFO - > Task :geckoview:processWithGeckoBinariesDebugManifest UP-TO-DATE
[task 2019-01-17T23:17:01.563Z] 23:17:01 INFO - > Task :geckoview:generateWithGeckoBinariesDebugRFile UP-TO-DATE
[task 2019-01-17T23:17:01.862Z] 23:17:01 INFO - > Task :geckoview:compileWithGeckoBinariesDebugKotlin UP-TO-DATE
[task 2019-01-17T23:17:01.863Z] 23:17:01 INFO - > Task :geckoview:prepareLintJar UP-TO-DATE
[task 2019-01-17T23:17:01.863Z] 23:17:01 INFO - > Task :geckoview:generateWithGeckoBinariesDebugSources UP-TO-DATE
[task 2019-01-17T23:17:01.962Z] 23:17:01 INFO - > Task :geckoview:javaPreCompileWithGeckoBinariesDebug UP-TO-DATE
[task 2019-01-17T23:17:01.962Z] 23:17:01 INFO - > Task :geckoview:compileWithGeckoBinariesDebugJavaWithJavac UP-TO-DATE
[task 2019-01-17T23:17:03.362Z] 23:17:03 INFO - > Task :geckoview:apiGenerateWithGeckoBinariesDebug
[task 2019-01-17T23:17:03.362Z] 23:17:03 INFO - Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
[task 2019-01-17T23:17:03.362Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/EventDispatcher.java:17: error: cannot find symbol
[task 2019-01-17T23:17:03.363Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.363Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.363Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.363Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java:40: error: cannot find symbol
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashHandler.java:21: error: cannot find symbol
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java:14: error: cannot find symbol
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.364Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoSurface.java:16: error: cannot find symbol
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - import static org.mozilla.geckoview.BuildConfig.DEBUG_BUILD;
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoSurface.java:16: error: static import only from classes and interfaces
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - import static org.mozilla.geckoview.BuildConfig.DEBUG_BUILD;
[task 2019-01-17T23:17:03.365Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsAudioRenderer.java:13: error: cannot find symbol
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsRendererBase.java:9: error: cannot find symbol
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.366Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java:43: error: cannot find symbol
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsVideoRenderer.java:13: error: cannot find symbol
[task 2019-01-17T23:17:03.367Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHLSDemuxerWrapper.java:12: error: cannot find symbol
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.368Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHLSResourceWrapper.java:9: error: cannot find symbol
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java:16: error: cannot find symbol
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.369Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/GeckoJarReader.java:16: error: cannot find symbol
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/GeckoLoader.java:12: error: cannot find symbol
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - import org.mozilla.geckoview.BuildConfig;
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - ^
[task 2019-01-17T23:17:03.370Z] 23:17:03 INFO - symbol: class BuildConfig
[task 2019-01-17T23:17:03.371Z] 23:17:03 INFO - location: package org.mozilla.geckoview
[task 2019-01-17T23:17:03.371Z] 23:17:03 INFO - 15 warnings
[task 2019-01-17T23:17:03.462Z] 23:17:03 INFO - > Task :geckoview:apiLintSingleWithGeckoBinariesDebug
[task 2019-01-17T23:17:03.562Z] 23:17:03 INFO - > Task :geckoview:apiCompatLintWithGeckoBinariesDebug
[task 2019-01-17T23:17:03.562Z] 23:17:03 INFO - > Task :geckoview:apiDiffWithGeckoBinariesDebug
[task 2019-01-17T23:17:03.562Z] 23:17:03 INFO - > Task :geckoview:apiLintHelpWithGeckoBinariesDebug SKIPPED
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - > Task :geckoview:apiChangelogCheckWithGeckoBinariesDebug FAILED
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - ERROR: The api changelog file is out of date. Please update the file at
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/doc-files/CHANGELOG.md
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - and then modify the [api-version] line as following:
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - >>>>
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - [api-version]: 45d1d8774e913a3077d7c489274184fd301f14fc
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - <<<<
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - FAILURE: Build failed with an exception.
[task 2019-01-17T23:17:03.563Z] 23:17:03 INFO - * What went wrong:
[task 2019-01-17T23:17:03.564Z] 23:17:03 INFO - Execution failed for task ':geckoview:apiChangelogCheckWithGeckoBinariesDebug'.
[task 2019-01-17T23:17:03.564Z] 23:17:03 INFO - > Process 'command 'python'' finished with non-zero exit value 10
[task 2019-01-17T23:17:03.564Z] 23:17:03 INFO - * Try:
[task 2019-01-17T23:17:03.564Z] 23:17:03 INFO - Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
[task 2019-01-17T23:17:03.564Z] 23:17:03 INFO - * Get more help at https://help.gradle.org
[task 2019-01-17T23:17:03.564Z] 23:17:03 INFO - Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
[task 2019-01-17T23:17:03.564Z] 23:17:03 INFO - Use '--warning-mode all' to show the individual deprecation warnings.
[task 2019-01-17T23:17:03.565Z] 23:17:03 INFO - See https://docs.gradle.org/4.10.2/userguide/command_line_interface.html#sec:command_line_warnings
[task 2019-01-17T23:17:03.565Z] 23:17:03 INFO - BUILD FAILED in 8s
[task 2019-01-17T23:17:03.565Z] 23:17:03 INFO - 18 actionable tasks: 5 executed, 13 up-to-date
[task 2019-01-17T23:17:04.006Z] 23:17:04 INFO - SUITE-START | android-api-lint
[task 2019-01-17T23:17:04.006Z] 23:17:04 INFO - SUITE-END | android-api-lint
[task 2019-01-17T23:17:04.021Z] 23:17:04 ERROR - Return code: 1
[task 2019-01-17T23:17:04.021Z] 23:17:04 ERROR - 1 not in success codes: [0]
[task 2019-01-17T23:17:04.021Z] 23:17:04 WARNING - setting return code to 2
[task 2019-01-17T23:17:04.021Z] 23:17:04 FATAL - Halting on failure while running ['/usr/bin/python2.7', 'mach', '--log-no-times', 'android', 'api-lint']

Flags: needinfo?(esawin)
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c92a0281831e
[1.0] Add experimental ad-blocking category to the Tracking Protection API.
Flags: needinfo?(esawin)

https://hg.mozilla.org/mozilla-central/rev/c92a0281831e

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

We will need to uplift these new categories to 65 Beta so Focus 9.0 can use them for its ad blocking experiment.

status-geckoview66: affected → fixed

Let's plan to go straight to the GV65 relbranch since that'll be a thing early next week anyway.

status-firefox65: affected → wontfix
tracking-geckoview65: --- → +
tracking-geckoview66: --- → +

I'm waiting for the Shavar fix (it doesn't accept two-part blocklist names) before requesting uplift, since I would like to verify the new lists locally.

They wouldn't accept any shavar server fix, so we had to change the list names to three-part names.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6063ab0285c7
[2.0] Rename blocklist names to use a three-part naming scheme. r=dimi
Attachment #9036916 - Flags: approval-mozilla-geckoview65?
Attachment #9038862 - Flags: approval-mozilla-geckoview65?

https://hg.mozilla.org/mozilla-central/rev/6063ab0285c7

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED

The GV 65 relbranch has been created, so we can uplift this fix (as soon as the uplift request is approved).

https://hg.mozilla.org/releases/mozilla-release/shortlog/GECKOVIEW_65_RELBRANCH

64=wontfix because we don't need to uplift to the GV 64 relbranch.

Comment on attachment 9036916 [details]
Bug 1517641 - [1.0] Add experimental ad-blocking category to the Tracking Protection API.

Approved for the GV65 release.

Attachment #9036916 - Flags: approval-mozilla-geckoview65? → approval-mozilla-geckoview65+
Attachment #9038862 - Flags: approval-mozilla-geckoview65? → approval-mozilla-geckoview65+
You need to log in before you can comment on or make changes to this bug.