Closed Bug 1517674 Opened 2 years ago Closed 2 years ago

Rename JS_NewDateObject and JS_ObjectIsDate to JS:: versions of the same, and move their declarations to js/public/Date.h and their implementations to js/src/jsdate.cpp

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Patch
11.76 KB, patch
arai
: review+
Details | Diff | Splinter Review 
No description provided.
Attached patch Patch — — Splinter Review 
DOM bindings code that wants to work with Date objects uses the stuff in dom/bindings/Date.h, and that header already #includes js/Date.h, so it's not necessary to alter Codegen.py inclusions to make this change.

(This is also a test of whether sfink's patch for bug 1517643 will work.  Fingers crossed!)
Attachment #9034334 - Flags: review?(arai.unmht)
Attachment #9034334 - Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a374ac233cd
Rename JS_NewDateObject and JS_ObjectIsDate to JS:: versions of the same, and move their declarations to js/public/Date.h and their implementations to js/src/jsdate.cpp.  r=arai
https://hg.mozilla.org/mozilla-central/rev/0a374ac233cd
Waldo, for some reason, none of the bugs you pushed that day got marked as fixed.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7f30c265e9
Rename JS_NewDateObject and JS_ObjectIsDate to JS:: versions of the same, and move their declarations to js/public/Date.h and their implementations to js/src/jsdate.cpp.  r=arai
You need to log in before you can comment on or make changes to this bug.