1517682 - Drop preferences for CSS properties that have been enabled by default since 2016

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I did choose '2016' for no particular reason. :)

There are two exceptions;
1) layout.css.touch_action.enabled
 It's not clear to me that we should simply drop this pref as far as I read the comment on the pref[1].
2) layout.css.scroll-snap.enabled
 Initially I was going to remove this, but now I am trying to coexist the shorhand scroll-snap-type and the longhand scroll-snap-type with toggling a new preference, if it works this old pref will be replaced by the new one, if it fails I am going to drop this in a later bug.

[1] https://hg.mozilla.org/mozilla-central/file/b762378e8c7e/modules/libpref/init/all.js#l5294

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1517682 - Drop layout.css.box-decoration-break.enabled pref. r?heycam!

It was enabled by default in bug 1006326.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1517682 - Drop layout.css.color-adjust.enabled pref. r?heycam!

It was enabled by default in bug 1209273.

Depends on D15702

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1517682 - Drop layout.css.image-orientation.enabled pref. r?heycam!

It was enabled by default in bug 825771.

Depends on D15703

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1517682 - Drop layout.css.isolation.enabled pref. r?heycam!

It was enabled by default in bug 1091885.

Depends on D15704

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1517682 - Drop layout.css.mix-blend-mode.enabled pref. r?heycam!

It was enabled by default in bug 952643.

Depends on D15705

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1517682 - Drop layout.css.scroll-behavior.property-enabled pref. r?heycam!

It was enabled by default in bug 1041833 (for desktops) and
bug 1087562 (for Fennect).

Depends on D15706

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1517682 - Drop layout.css.background-blend-mode.enabled pref. r?heycam!

It was enabled by default in bug 970600.

Depends on D15707

Comment 8

[Cameron McCormack (:heycam)]

Thanks for digging out the bugs where these prefs were enabled by default, that was useful!

Comment 9

[Cameron McCormack (:heycam)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> There are two exceptions;
> 1) layout.css.touch_action.enabled
>  It's not clear to me that we should simply drop this pref as far as I read
> the comment on the pref[1].

I think that comment means that we don't disable the pref even on configurations where we don't implement touch events.  Unless we were going to change that, then I think it should be safe to remove the pref.

(According to MDN there are some new values of this property that we don't support, but that is from V2 of the Pointer Events spec, and I don't think we'll need to disable the V1 values.)

Comment 10

[Hiroyuki Ikezoe (:hiro)]

(In reply to Cameron McCormack (:heycam) from comment #9)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> > There are two exceptions;
> > 1) layout.css.touch_action.enabled
> >  It's not clear to me that we should simply drop this pref as far as I read
> > the comment on the pref[1].
> 
> I think that comment means that we don't disable the pref even on
> configurations where we don't implement touch events.  Unless we were going
> to change that, then I think it should be safe to remove the pref.

Thanks for the clarification.  I will drop it in the next round.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a48406a5805
Drop layout.css.box-decoration-break.enabled pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/a8a86cdb127b
Drop layout.css.color-adjust.enabled pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/3e992b70fb1b
Drop layout.css.image-orientation.enabled pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/8f2b23321d9a
Drop layout.css.isolation.enabled pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/f0fd2ca467ef
Drop layout.css.mix-blend-mode.enabled pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/88046e1983f9
Drop layout.css.scroll-behavior.property-enabled pref. r=heycam
https://hg.mozilla.org/integration/autoland/rev/348ab7a8ab4d
Drop layout.css.background-blend-mode.enabled pref. r=heycam

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5a48406a5805
https://hg.mozilla.org/mozilla-central/rev/a8a86cdb127b
https://hg.mozilla.org/mozilla-central/rev/3e992b70fb1b
https://hg.mozilla.org/mozilla-central/rev/8f2b23321d9a
https://hg.mozilla.org/mozilla-central/rev/f0fd2ca467ef
https://hg.mozilla.org/mozilla-central/rev/88046e1983f9
https://hg.mozilla.org/mozilla-central/rev/348ab7a8ab4d