1517690 - 112.83 - 120.65% raptor-assorted-dom-firefox (linux64, linux64-qr) regression on push a97b9b4c385e526301358abadfe1eb9039312d8b (Thu Jan 3 2019)

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ionuț Goldan [:igoldan]]

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a5c5e322deb7b3764583332a082753b4363c1dde&tochange=a97b9b4c385e526301358abadfe1eb9039312d8b

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

121%  raptor-assorted-dom-firefox linux64-qr opt      25.26 -> 55.73
118%  raptor-assorted-dom-firefox linux64 opt         25.35 -> 55.17
113%  raptor-assorted-dom-firefox linux64 pgo         25.63 -> 54.55


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=18575

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/Performance_sheriffing/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Ionuț Goldan [:igoldan]]

Here are the Gecko profiles for assorted dom on Linux 64bit Quantum Render:

before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FRdjTQqQfR3Oa3lmCGWMW-g%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_raptor-assorted-dom-firefox.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FcNJ2IJQ5TXG6OlTwYyUklg%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_raptor-assorted-dom-firefox.zip


and on Linux 64bit PGO:

before: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FHeREJg7-TPSRn-J65vn9Mw%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_raptor-assorted-dom-firefox.zip

after: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FWOKVe5rHTbWA0ubJZhgz4Q%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_raptor-assorted-dom-firefox.zip

Comment 2

[Jan de Mooij [:jandem]]

D'oh, I think I know what this is: I forgot to update the BaselineInspector code. That's a bit brittle and something we want to fix longer-term, but this should be an easy fix.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1517690 - Fix BaselineInspector to match new CacheIR ops for WindowProxy unwrapping. r?evilpie!

Comment 4

[Jan de Mooij [:jandem]]

Fixes the regression:

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=5e879f7e6dc3a2f67bcfca431fe31f0c8af7edf0&originalSignature=b25cc780ef12a59804e12f7e0f729dbf9294d090&newSignature=b25cc780ef12a59804e12f7e0f729dbf9294d090&framework=10&selectedTimeRange=86400

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b3fc8b91280
Fix BaselineInspector to match new CacheIR ops for WindowProxy unwrapping. r=evilpie

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4b3fc8b91280

Comment 7

[Ionuț Goldan [:igoldan]]

I can confirm this got fixed. Thanks a lot! \0/

== Change summary for alert #18609 (as of Fri, 04 Jan 2019 15:49:19 GMT) ==

Improvements:

 54%  raptor-assorted-dom-firefox linux64-qr opt      55.64 -> 25.38
 54%  raptor-assorted-dom-firefox linux64 opt         55.55 -> 25.71
 52%  raptor-assorted-dom-firefox linux64 pgo         53.79 -> 25.80

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=18609