112.83 - 120.65% raptor-assorted-dom-firefox (linux64, linux64-qr) regression on push a97b9b4c385e526301358abadfe1eb9039312d8b (Thu Jan 3 2019)

VERIFIED FIXED in Firefox 66

Status

()

defect
VERIFIED FIXED
8 months ago
5 months ago

People

(Reporter: igoldan, Assigned: jandem)

Tracking

(Blocks 1 bug, {perf, regression})

unspecified
mozilla66
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 unaffected, firefox66 verified)

Details

Attachments

(1 attachment)

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a5c5e322deb7b3764583332a082753b4363c1dde&tochange=a97b9b4c385e526301358abadfe1eb9039312d8b

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

121%  raptor-assorted-dom-firefox linux64-qr opt      25.26 -> 55.73
118%  raptor-assorted-dom-firefox linux64 opt         25.35 -> 55.17
113%  raptor-assorted-dom-firefox linux64 pgo         25.63 -> 54.55


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=18575

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/Performance_sheriffing/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling
Component: General → JavaScript Engine
Product: Testing → Core
Flags: needinfo?(jdemooij)
D'oh, I think I know what this is: I forgot to update the BaselineInspector code. That's a bit brittle and something we want to fix longer-term, but this should be an easy fix.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b3fc8b91280
Fix BaselineInspector to match new CacheIR ops for WindowProxy unwrapping. r=evilpie
https://hg.mozilla.org/mozilla-central/rev/4b3fc8b91280
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
I can confirm this got fixed. Thanks a lot! \0/

== Change summary for alert #18609 (as of Fri, 04 Jan 2019 15:49:19 GMT) ==

Improvements:

 54%  raptor-assorted-dom-firefox linux64-qr opt      55.64 -> 25.38
 54%  raptor-assorted-dom-firefox linux64 opt         55.55 -> 25.71
 52%  raptor-assorted-dom-firefox linux64 pgo         53.79 -> 25.80

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=18609
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.