Add a new way to add new jobs to a push (a la `mach try fuzzy`)
Categories
(Tree Management :: Treeherder, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: KWierso, Assigned: KWierso)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
`mach try fuzzy` lets you select runnable jobs from the command line, generated from the task graph it generates. You can search through the possible runnable jobs and add specific jobs to a list. When you're done, the list of selected jobs are submitted to try. I want to add a feature to Treeherder similar to `mach try fuzzy`, as an alternative to the current "add new jobs" feature. Click the new button, and a modal dialog opens and displays the list of runnable jobs. You can filter the list with a searchbar, and select jobs from the list, and the final list is submitted as an action task, which will trigger the selected jobs (and any dependencies they may need). Quick demo of the feature as it's currently written: https://www.youtube.com/watch?v=Y1yv8bWG-cs (apologies for the long second half while I wait for the add-jobs task to show up, complete, and trigger the new job... I forgot to hit the pause button during the recording). PR coming tomorrow.
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Comment on attachment 9034516 [details] [review] GitHub Pull Request I've added some initial comments. Once updated for the main review Cameron might be the best reviewer :-)
Assignee | ||
Comment 3•5 years ago
|
||
Comment on attachment 9034516 [details] [review]
GitHub Pull Request
Comments addressed.
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Comment on attachment 9034516 [details] [review]
GitHub Pull Request
Requested a few changes. This should be cool, when it's done. Thanks! :)
Assignee | ||
Comment 5•5 years ago
|
||
Comment on attachment 9034516 [details] [review]
GitHub Pull Request
Round 2 :)
Layout issues fixed, other comments addressed, and an issue I found where the "remove selected" button wasn't getting disabled in all situations.
Comment 6•5 years ago
|
||
Comment on attachment 9034516 [details] [review]
GitHub Pull Request
Just a few more changes requested. Super close!
Comment 7•5 years ago
|
||
What's the state of this work? I just got burned by https://bugzilla.mozilla.org/show_bug.cgi?id=1272212#c4 again...
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9034516 [details] [review] GitHub Pull Request Oh right, this pull request. Sorry for dropping this. Fixed up a few dangling issues. I think this is ready for a final round of review, Cam.
Comment 9•5 years ago
|
||
Comment on attachment 9034516 [details] [review] GitHub Pull Request Just one small deprecation issue to fix.
Assignee | ||
Comment 10•5 years ago
|
||
This landed in https://github.com/mozilla/treeherder/commit/2476432dfd6130e7c96a4977a3ff3b6756f3bfe3
Updated•2 years ago
|
Description
•