Closed Bug 1517736 Opened 10 months ago Closed 9 months ago

[wpt-sync] Sync PR 14715 - Prevent webdriver client Session.close() exception

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14715 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14715
Details from upstream follow.

Michael[tm] Smith <mike@w3.org> wrote:
>  Prevent webdriver client Session.close() exception
>  
>  This change adds handling for the case when the call to
>  self.send_session_command("DELETE", "window") in Session.close() in
>  tools/webdriver/webdriver/client.py returns None.
>  
>  Otherwise without this change, the code ends up checking len() on the
>  return value of self.send_session_command("DELETE", "window"), which can
>  result in a "TypeError: object of type 'NoneType' has no len()" exception.
>  
>  Fixes https://github.com/web-platform-tests/wpt/issues/14714
>  
>  ---
>  
>  If the code in this patch isn’t the right/best way (or the most idiomatic
>  way in Python) to deal with the problem in #14714, then let’s use this PR
>  branch to update the patch to fix it the right way.
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c23b30c00598
[wpt PR 14715] - Prevent webdriver client Session.close() exception, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f551b250bc43
[wpt PR 14715] - Prevent webdriver client Session.close() exception, a=testonly
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.