Closed Bug 1517744 Opened 5 years ago Closed 4 years ago

controlvariant is not initialised correctly in signup.js

Categories

(Firefox :: Pocket, defect)

Product:
Firefox
Component:
Pocket
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INACTIVE

People

(Reporter: standard8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: coverity) 

controlvariant is not initialised correctly in signup.js:

https://searchfox.org/mozilla-central/rev/ecf61f8f3904549f5d65a8a511dbd7ea4fd1a51d/browser/components/pocket/content/panels/js/signup.js#23

```
this.inoverflowmenu = false;
this.controlvariant;
this.pockethost = "getpocket.com";
```

It should either be initialised to something (false/null)? or not at all.

This bug has been closed due to inactivity and/or the potential for this bug to no longer be an issue with the new Discovery Stream-powered New Tab experience, and improvements to Pocket’s integration with Firefox.

Please help us triage by reopening if this issue still persists and should be addressed.

Thanks!

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.