Closed Bug 1517762 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14718 - [css-grid] Fix auto repeat with multiple tracks and gutters

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 14718 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14718
Details from upstream follow.

shenyu.tcv <shenyu.tcv@gmail.com> wrote:
>  [css-grid] Fix auto repeat with multiple tracks and gutters
>  
>  The code that computes the number of auto repeat tracks wrongly assumes that
>  the second argument of the repeat() notation is a single track function. That
>  was true in the beginning, however specs were later on modified to allow a
>  \<track-list>. We support a \<track-list> as a second argument since long ago
>  but the code that computes the number of auto-repeat tracks was never
>  updated.
>  
>  This patch modifies two places that relates to the gaps between the
>  auto-repeat tracks, which ensures the proper total length. 4 test expected
>  values in the auto-repeat-huge-grid.html are also modified.
>  
>  BUG=813511
>  
>  Change-Id: Iaf00e7d595a800f07cbe630868f30b82ad7fbd4d
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1393136
>  WPT-Export-Revision: e90393048c96ed85484a3b080b924f78bd29e333
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd89e26973f
[wpt PR 14718] - [css-grid] Fix auto repeat with multiple tracks and gutters, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab8f60bec199
[wpt PR 14718] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/500010d67964
[wpt PR 14718] - [css-grid] Fix auto repeat with multiple tracks and gutters, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/9da5b9790413
[wpt PR 14718] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/500010d67964
https://hg.mozilla.org/mozilla-central/rev/9da5b9790413

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.