Closed
Bug 1517769
Opened 5 years ago
Closed 5 years ago
History sidebar doesn't need to reference "this.TelemetryStopwatch"
Categories
(Firefox :: Bookmarks & History, enhancement, P3)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
Picked up in a Coverity scan, historySidebar.js is currently referencing:
this.TelemetryStopwatch.finish("HISTORY_LASTVISITED_TREE_QUERY_TIME_MS");
it should just be:
TelemetryStopwatch.finish("HISTORY_LASTVISITED_TREE_QUERY_TIME_MS");
TelemetryStopwatch is in the global scope and we don't reference it with `this` anywhere else.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2482a109b0e2 History sidebar shouldn't reference TelemetryStopwatch via 'this'. r=mak
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•