1517809 - Fullscreen transition is not smooth

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P3)

Description

[csheany]

+++ This bug was initially created as a clone of Bug #1500719 +++

Steps to reproduce:
1. open attachment 9018847 [details]
2. click "fullscreen" button in the page

Expected result:
The transition should be smooth

Actual result:
The transition is stepped

Comment 1

[csheany]

Liz, would you mind taking a look?

Comment 2

[miralobontiu]

I was able to reproduce the issue on Release 64.0.1 on Samsung Galaxy Tab S3 (Android 8).
Confirming the issue.

Comment 3

[Andrew Overholt [:overholt]]

Is it possible to get this fixed in 65? Do we need a regression range?
TOo late for a 64 dot release.

Comment 4

[:sdaswani]

Andrew, if we want to get ship this to beta, this is probably a P1? I'm just a bit confused looking at the 'source' ticket https://bugzilla.mozilla.org/show_bug.cgi?id=1500719 about the priority here. cc Liz

Comment 5

[Andrew Overholt [:overholt]]

I have no context on the priority; it just seemed like something that was not a good regression when it came up in our regression triage meeting earlier today :)

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

This didn't strike me as a P1 issue - it doesn't affect major functionality and isn't a top crash or a security issue. I think Andrew was asking about this because we came across it in this morning's weekly regression triage rather than because it is a particular priority.

Comment 7

[Chris Peterson [:cpeterson]]

Does this fullscreen transition issue affect GeckoView in Focus Nightly?

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Oana, can your team check on this in Focus Nightly?

Comment 9

[Oana Horvath [:ohorvath]]

It doesn't reproduce on Focus Nightly GV65. On Focus the transition is a lot smoother (even better than Chrome). Probably because it doesn't show that toast notification after entering fullscreen(?).
devices: HTC Desire 820 (Android 6.0.1), Samsung Galaxy Note 8 (Android 8.0)

Comment 10

[Oana Horvath [:ohorvath]]

Attachment: focus-example.mp4

Comment 11

[Chris Peterson [:cpeterson]]

(In reply to Oana Horvath from comment #9)

It doesn't reproduce on Focus Nightly GV65. On Focus the transition is a lot smoother (even better than Chrome). Probably because it doesn't show that toast notification after entering fullscreen(?).

Thanks. The Focus transition looks good. Since this looks like a Fennec-only bug, I will remove the [geckoview] whiteboard label.

Your hypothesis about Fennec's toast notification makes a lot of sense.

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

The notification is a security feature. We added it after getting several reports from security researchers who were able to spoof. Geckoview should have this.

Comment 13

[Chris Peterson [:cpeterson]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #12)

The notification is a security feature. We added it after getting several reports from security researchers who were able to spoof. Geckoview should have this.

James, should the full screen message be implemented in GV or in the app embedding GV? The message will need to be localized.

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Chris Peterson [:cpeterson] from comment #13)

(In reply to Kevin Brosnan [:kbrosnan] from comment #12)

The notification is a security feature. We added it after getting several reports from security researchers who were able to spoof. Geckoview should have this.

James, should the full screen message be implemented in GV or in the app embedding GV? The message will need to be localized.

This should be handled by the app. We can add guidance for this to the docs, though.

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

That seems error prone. I can understand why some apps may want to disable it but having a safe default would be good. Maybe AC is the correct place to have that. Is there a fullscreen component?

Comment 16

[Sebastian Kaspari (:sebastian; :pocmo)]

Maybe AC is the correct place to have that. Is there a fullscreen component?

We do handle some fullscreen related state changes in the feature-session component. We could consider adding this there.

Comment 17

[csheany]

Dhhdhh

Comment 18

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.