Remove --theme-icon-checked-filter and replace with fill property

RESOLVED FIXED in Firefox 66

Status

enhancement
P3
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

unspecified
Firefox 66

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
You can fill the icon with -moz-context-properties: fill; fill: var(--theme-toolbar-checked-color); instead of the custom SVG filter.
Priority: -- → P3
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #9035604 - Attachment description: Bug 1517948 - Consolidate checked icon styles and remove checked icon filter. r=pbro → Bug 1517948 - Consolidate icon styles and remove checked icon filter. r=fvsch

Comment 2

5 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1114f74deed5
Consolidate icon styles and remove checked icon filter. r=fvsch

Comment 3

5 months ago

Backed out for failures at devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1114f74deed5e8e31df3c69a6f0a8d38b38eef19

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221615619&repo=autoland&lineNumber=4531

[task 2019-01-13T20:54:47.284Z] 20:54:47 INFO - TEST-START | devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js
[task 2019-01-13T20:54:48.094Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2019-01-13T20:54:48.115Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2019-01-13T20:54:48.216Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2019-01-13T20:54:48.237Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2019-01-13T20:54:48.334Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2019-01-13T20:54:48.356Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2019-01-13T20:54:48.372Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2019-01-13T20:54:48.429Z] 20:54:48 INFO - GECKO(1085) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2019-01-13T20:54:48.480Z] 20:54:48 INFO - TEST-INFO | started process screentopng
[task 2019-01-13T20:54:48.959Z] 20:54:48 INFO - TEST-INFO | screentopng: exit 0
[task 2019-01-13T20:54:48.959Z] 20:54:48 INFO - Buffered messages logged at 20:54:47
[task 2019-01-13T20:54:48.960Z] 20:54:48 INFO - Entering test bound
[task 2019-01-13T20:54:48.960Z] 20:54:48 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,%0A%20%20%3Cstyle%20type%3D'text%2Fcss'%3E%0A%20%20%20%20%23shape%20%7B%0A%20%20%20%20%20%20width%3A%20800px%3B%0A%20%20%20%20%20%20height%3A%20800px%3B%0A%20%20%20%20%20%20clip-path%3A%20circle(25%25)%3B%0A%20%20%20%20%7D%0A%20%20%20%20div%20%7B%0A%20%20%20%20%20%20clip-path%3A%20circle(30%25)%3B%0A%20%20%20%20%7D%0A%20%20%3C%2Fstyle%3E%0A%20%20%3Cdiv%20id%3D%22shape%22%3E%3C%2Fdiv%3E%0A
[task 2019-01-13T20:54:48.960Z] 20:54:48 INFO - Tab added and finished loading
[task 2019-01-13T20:54:48.961Z] 20:54:48 INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/inspector/rules/test/doc_frame_script.js
[task 2019-01-13T20:54:48.962Z] 20:54:48 INFO - Opening the inspector
[task 2019-01-13T20:54:48.964Z] 20:54:48 INFO - Opening the toolbox
[task 2019-01-13T20:54:48.965Z] 20:54:48 INFO - Buffered messages logged at 20:54:48
[task 2019-01-13T20:54:48.966Z] 20:54:48 INFO - Toolbox opened and focused
[task 2019-01-13T20:54:48.968Z] 20:54:48 INFO - Selecting the node for '#shape'
[task 2019-01-13T20:54:48.968Z] 20:54:48 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js | Shapes highlighter toggles exist in the DOM. -
[task 2019-01-13T20:54:48.970Z] 20:54:48 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js | Shapes highlighter toggle buttons are not active. -
[task 2019-01-13T20:54:48.970Z] 20:54:48 INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js | Shape highlighter toggle is not hidden -
[task 2019-01-13T20:54:48.972Z] 20:54:48 INFO - Buffered messages finished
[task 2019-01-13T20:54:48.973Z] 20:54:48 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js | Overwritten shape highlighter toggle is not visible - Got inline-block, expected none
[task 2019-01-13T20:54:48.974Z] 20:54:48 INFO - Stack trace:
[task 2019-01-13T20:54:48.975Z] 20:54:48 INFO - chrome://mochikit/content/browser-test.js:test_is:1318
[task 2019-01-13T20:54:48.976Z] 20:54:48 INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_shapes-toggle_02.js:null:44
[task 2019-01-13T20:54:48.976Z] 20:54:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1108
[task 2019-01-13T20:54:48.977Z] 20:54:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1099
[task 2019-01-13T20:54:48.978Z] 20:54:48 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:997
[task 2019-01-13T20:54:48.978Z] 20:54:48 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-01-13T20:54:48.979Z] 20:54:48 INFO - Leaving test bound
[task 2019-01-13T20:54:48.980Z] 20:54:48 INFO - Removing tab.
[task 2019-01-13T20:54:48.981Z] 20:54:48 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-01-13T20:54:48.983Z] 20:54:48 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-01-13T20:54:48.984Z] 20:54:48 INFO - Tab removed and finished closing
[task 2019-01-13T20:54:48.985Z] 20:54:48 INFO - GECKO(1085) | MEMORY STAT | vsize 2112MB | residentFast 375MB | heapAllocated 125MB

Backout: https://hg.mozilla.org/integration/autoland/rev/6be3e8a5a643d857094a41a806ab8d440095c3c2

Flags: needinfo?(ntim.bugs)

Comment 4

5 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e5f1a57990a6
Consolidate icon styles and remove checked icon filter. r=fvsch
Assignee

Updated

5 months ago
Flags: needinfo?(ntim.bugs)

Comment 5

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.