1517973 - Add-on temporarily replaced disappears on crash

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Rafael Gomes]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

1. Install any add-on from the AMO
2. Extract the contents of the add-on's .xpi file to a folder
3. Modify the manifest.json file to include the add-on's ID (see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings)
4. Load the modified manifest.json file as a temporary add-on (because it has the same ID as the installed add-on, it will replace the installed add-on until the browser is restarted)
5. Kill the Firefox process


Actual results:

The add-on disappeared from my list of installed add-ons.


Expected results:

The add-on should have remained in my list of installed add-ons and have been restored to its previous installed version. This is what happens when the browser is restarted, so it should also happen when the browser crashes.

Comment 1

[Daniel_A[:daschilean] [Please contact - [e-mail]]]

Hi Rafael,

Could you please disable all the add-ons and after enable each add-on one by one to see which one caused this issue? Thanks

Comment 2

[Rafael Gomes]

No, because that has nothing to do with it, did you even read?

Comment 3

[Rares Doghi, Desktop QA]

Hi, sorry about that, lets try this again:

I have Installed the grammarly addon : https://addons.mozilla.org/en-US/firefox/addon/grammarly-1/?src=search

I have unziped the file to a folder and changed the Manifest Json to include this key

"browser_specific_settings": {
"gecko": {
"id": "87677a2c52b84ad3a151a4a72f5bd3c4@jetpack",
"strict_min_version": "42.0"
}
},

Now in about:debugging I check the allow temporary add-ons and loaded the modified manifest file and yes it replaces the existing add-on, but after restarting the browser I no longer see the extension loaded from my pc just the installed add-on.

I tried this with Nightly 67.0a1 (2019-01-29) on Ubuntu 18.04 as well as Windows 10 and I cant seem to reproduce what youre seeing. Can you please download our latest nightly build and see if the issue still occurs ? or if Im doing something wrong like missing a step or something. We would like to get to the bottom of this but we cant seem to reproduce this issue, maybe its a specific addon ?

You can find the build here : https://nightly.mozilla.org/

Comment 4

[Rafael Gomes]

The browser has to crash. Restarting the browser correctly restores the installed version, but if the browser crashes, then the add-on simply disappears, instead of being restored to the installed version.

On both Windows and Linux, this can be accomplished by opening the task manager and killing Firefox.

Comment 5

[Rares Doghi, Desktop QA]

Yep, Thanks for the extra info Rafael, I managed to reproduce this issue, I'll set a component for it.