1517974 - Theme the splitters when the tree are themed

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

Actually the splitters are hard coded and don't adapt with the themes. We can use the --sidebar-border-color variable for this.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1517974-themed-splitters.patch

This adds to all splitters the --sidebar-border-color when existing.

I also fixed the conversation header on the top right of the chat where some lines aren't well visible in dark mode.

Lightning is untouched as I wait for bug 1504190.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: test-webext-theme.xpi

This is my test theme. The splitters should be green.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9034575 [details] [diff] [review]
1517974-themed-splitters.patch

That theme gives sore eyes. CSS reviews are not my favourite. Yes, with the test theme lots of splitters are green now. Without the theme, things still look OK.

In chat, the splitter in the middle section:

22:15:59 - jorgk-testing-dont-talk-to-me has left the room (Quit: Client exited).
22:17:04 - jorgk-testing-dont-talk-to-me [[e-mail]] entered the room.

---------- <=== this one
Let's type something here

Can only be moved up a little bit. There is space for about three lines. In TB 60 ESR it can be moved up a whole lot more. Is that a bug?

Comment 4

[Richard Marti (:Paenglab)]

Looks like a bug. Maybe from the textbox conversion to HTML.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a9a6dd5c4e9f
Apply --sidebar-border-color to the splitters when we use themed trees. r=jorgk