Closed Bug 1517976 Opened 5 years ago Closed 5 years ago

Test for the "first paint" case of bug 1509575

Categories

(Core :: Panning and Zooming, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(1 file)

      No description provided.
Blocks: 1509575
We need to setup a case where the visual viewport is smaller than the layout
viewport. Faking a pinch zoom through touch events is imprecise, whereas calling
windowUtils.setResolutionAndScaleTo(value > 1) to simulate the equivalent
effect of a pinch-zoom on the page led to the subsequent scroll attempt failing
quite often even after calling waitForApzFlushedRepaints().

So instead, we set up a very wide layout viewport through the meta viewport tag,
which on Desktop means additionally enabling the dom.meta-viewport.enabled pref.
(In reply to Jan Henning [:JanH] from comment #1)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=e3d1d3f851c0bcdb8122b6b84a290c1d42d79b37

Great, the original push is restricted only to that particular test paths, but the retriggers totally ignore that and run something completely different...
So the test isn't fundamentally broken anywhere, but that Try push is totally useless with regards to possible intermittent failures.

This depends on "Part 7: Generally enable Visual Viewport for Mochitests. r?botond" from bug 1498812.

Depends on: 1498812
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/0355f47af6ce
Test that resetting WindowUtils.isFirstPaint doesn't clobber APZ scroll position. r=botond
Flags: needinfo?(jh+bugzilla)

helper_bug1509575.html | visual viewport did scroll - got 18, expected 100

I wonder if perhaps the test is running in a window that sufficiently wide that 2000px of horizontal content is not enough to give it a 100px scroll range.

Depends on: 1519594
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/81378c45a359
Test that resetting WindowUtils.isFirstPaint doesn't clobber APZ scroll position. r=botond
Flags: needinfo?(jh+bugzilla)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: