Consider saving form history when a form is "submitted" without a `submit` event
Categories
(Toolkit :: Form Manager, enhancement, P3)
Tracking
()
People
(Reporter: xidorn, Unassigned)
Details
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Are you expecting form history to fill an email you previously submitted or the username of a saved login?
Reporter | ||
Comment 2•6 years ago
|
||
Either is better than nothing. Ideally username of login, but since it uses separate pages for email and password, I can see there may be difficulties...
Comment 3•6 years ago
|
||
The two solutions belong in two different components so that's why I was asking… We already have a bug for using a saved username but as you said that's hard and won't be fixed anytime soon (bug 348941).
The reason it's not saved in form history is probably because there is no <form> submission. We could use the same heuristics we use for password manager to handle this but that may cause us to save a lot more form history and my actually be a net negative if it clutters up the form history.
Reporter | ||
Comment 4•6 years ago
|
||
There might be other heuristics we can use, for example in this case, the text field has placeholder "Email", and its name "email-field" also contains "email" so that might be usable as well...
Alternatively, for bug 348941, maybe we can track this kind of page sequence that a page followed by another page with just a password input, in which case we can backtrack the previous page to assume it may have a username field.
Reporter | ||
Comment 5•6 years ago
|
||
Note that, Chrome can correctly save the email address somehow, probably via form autofill (rather than login, as their password saving dialog doesn't contain the email address). Maybe we should just improve our heuristic for detecting email field.
Comment 6•6 years ago
|
||
(In reply to Xidorn Quan [:xidorn] UTC+11 from comment #5)
Note that, Chrome can correctly save the email address somehow, probably via form autofill (rather than login, as their password saving dialog doesn't contain the email address). Maybe we should just improve our heuristic for detecting email field.
yeah, we started on that in bug 1364602 but it stalled.
Updated•2 years ago
|
Description
•