1517996 - User Activity Report page should link back to the user's profile.

Status: ASSIGNED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If I load someone's user activity report (for instance, https://bugzilla.mozilla.org/page.cgi?id=user_activity.html&action=run&from=-14d&who=[e-mail] ), I can't currently get to that user's profile (in this case, https://bugzilla.mozilla.org/user_profile?user_id=308534 ). 

I feel like there should be a link to the user's profile somewhere.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: user menu

Or maybe include this menu somewhere on the page?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd be happy to take a stab at this if someone could hold my hand a bit. I assume it's https://github.com/mozilla-bteam/bmo/blob/56b4639601bbb91ffef70156a5a91114a584eb6d/extensions/BMO/template/en/default/pages/user_activity.html.tmpl that needs changed? 

Or would I need to edit https://github.com/bugzilla/bugzilla/blob/d7cf1c91949248222806f5a32f485b12eab8806f/template/en/default/account/profile-activity.html.tmpl ?

Comment 3

[David Lawrence [:dkl]]

(In reply to Wes Kocher (:KWierso) from comment #2)
> I'd be happy to take a stab at this if someone could hold my hand a bit. I
> assume it's
> https://github.com/mozilla-bteam/bmo/blob/
> 56b4639601bbb91ffef70156a5a91114a584eb6d/extensions/BMO/template/en/default/
> pages/user_activity.html.tmpl that needs changed? 
> 
> Or would I need to edit
> https://github.com/bugzilla/bugzilla/blob/
> d7cf1c91949248222806f5a32f485b12eab8806f/template/en/default/account/profile-
> activity.html.tmpl ?

Sure. You are welcome to take a shot at it. The first link is the template that will need to be updated, The other is for
viewing changes made to a users account by an admin.

It could probably be something as simple as a link under the filtering form called 'User Profile' that takes the user to the profile page directly.

dkl

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Mmm, so who is the email address, but the links to user profiles use the numeric user id. Is there some way to translate email to id?

Comment 5

[David Lawrence [:dkl]]

(In reply to Wes Kocher (:KWierso) from comment #4)

Mmm, so who is the email address, but the links to user profiles use the numeric user id. Is there some way to translate email to id?

Yeah who is the query parameter passed to the form so it will normally always be the email address in string form.

The place you would need to add addition code is:

https://github.com/mozilla-bteam/bmo/blob/56b4639601bbb91ffef70156a5a91114a584eb6d/extensions/BMO/lib/Reports/UserActivity.pm#L320

such as:

$var->{user} = Bugzilla::User->new({ name => $input->{who}, cached => 1 });

And then in the template:

https://github.com/mozilla-bteam/bmo/blob/56b4639601bbb91ffef70156a5a91114a584eb6d/extensions/BMO/template/en/default/pages/user_activity.html.tmpl#L106

You could add something like:

<p>
  <a href="[% basepath FILTER none %]user_profile?user_id=[% user.id FILTER uri %]">User Profile</a>
</p>

Comment 6

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

dkl, can I make you a mentor on this? We're in season for contributions for Outreachy.

Nevermind, Wes is taking it.

Comment 7

[Firefox Bug Husbandry Bot]

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: GitHub Pull Request

Totally untested, as I'm having issues getting docker or vagrant to run things locally.

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

@KWierso hmm, that's weird about the docker/vagrant issues.
If you have some spare time and you want to dig in, I've been working on this tooling recently.
Ping me on Matrix (@mitchhentges:mozilla.org) and we can figure out why it's not working :)