Closed Bug 1518000 Opened 2 years ago Closed 2 years ago

Move nsSVGString and nsSVGViewBox to the mozilla namespace

Categories

(Core :: SVG, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Assignee: nobody → longsonr
Attachment #9034598 - Flags: review?(jwatt)
Comment on attachment 9034598 [details] [diff] [review]
patch

Review of attachment 9034598 [details] [diff] [review]:
-----------------------------------------------------------------

There are a few places where you're touching lines where we use both 'virtual' and 'override'. For bonus points you could remove 'virtual' in those cases. :) (Up to you.)
Attachment #9034598 - Flags: review?(jwatt) → review+
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/640985215424
Move nsSVGString and nsSVGViewBox to the mozilla namespace r=jwatt
Landed "as is". I think fixing virtual override would be best done in a separate bug, ideally by some kind of automated script. Perhaps someone could teach ./mach clang-format to do that.
https://hg.mozilla.org/mozilla-central/rev/640985215424
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.