Closed
Bug 1518000
Opened 7 years ago
Closed 7 years ago
Move nsSVGString and nsSVGViewBox to the mozilla namespace
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file)
|
78.39 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → longsonr
Attachment #9034598 -
Flags: review?(jwatt)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9034598 [details] [diff] [review]
patch
Review of attachment 9034598 [details] [diff] [review]:
-----------------------------------------------------------------
There are a few places where you're touching lines where we use both 'virtual' and 'override'. For bonus points you could remove 'virtual' in those cases. :) (Up to you.)
Attachment #9034598 -
Flags: review?(jwatt) → review+
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/640985215424
Move nsSVGString and nsSVGViewBox to the mozilla namespace r=jwatt
|
|
Assignee | |
Comment 4•7 years ago
|
||
Landed "as is". I think fixing virtual override would be best done in a separate bug, ideally by some kind of automated script. Perhaps someone could teach ./mach clang-format to do that.
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•