1518038 - Add nsIThread.hasPendingHighPriorityEvents

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

I would expect we'll need this in many places when improving paint scheduling.
Unfortunately our thread implementation is super complicated atm and has some odd abstractions which are mostly unused - so the patch is way larger than it needs to be. Patch coming.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: haspendinghighprioevents.diff

This adds also nsThreadManager::MainThreadHasPendingHighPriorityEvents().

I tested this stuff locally by adding 
nsThreadManager::MainThreadHasPendingHighPriorityEvents() calls to ContentSink and we do have pending high prio events occasionally during parsing.

Lots of boilerplate code to check !mHighQueue->IsEmpty(aProofOfLock);

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a4422d311ba328b99f289ce278d67485ec25b33

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 9034625 [details] [diff] [review]
haspendinghighprioevents.diff

Review of attachment 9034625 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 1514011 comment 4 says that we might not need this?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

In that bug, but I actually need this elsewhere.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9fcbe28afda
Add nsIThread.hasPendingHighPriorityEvents, r=froydnj

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c9fcbe28afda