1518044 - Cleanup CONTENT_FRAME_TIME recording and try to record the same data for WR and non-WR where possible

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Matt Woodrow (:mattwoodrow)]

We currently implement all the code for CFT twice, and do slightly different things for each.

We should share code, and try to do the same as much as possible.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1518044 - Move CONTENT_FRAME_TIME calculation code into CompositorBridgeParent. r?jrmuizel

This shouldn't change any behaviour, just puts the code into a separate function so that it's easier to follow.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1518044 - Use shared CONTENT_FRAME_TIME calculation for non-WebRender. r?jrmuizel

This also results in us getting the CONTENT_FRAME_TIME profiler markers added for non-WR.

Depends on D15794

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1518044 - Record SVG and UPLOAD specific variants of CONTENT_FRAME_TIME using the vsync based timings. r?jrmuizel

We're switching to prefering the vsync version, so making these diagnostic equivalents use that timing should be more useful.
I think leaving the profiler marker (which uses ms, not vsync%) showing just the graphics component still makes sense.

Depends on D15795

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1518044 - Pass FULL_PAINT_TIME value to CONTENT_FRAME_TIME calculation for non-WR. r?jrmuizel

This will let us get the MissedCompositeLow/Mid/Long variants in the CFT_REASON telemetry output.

Depends on D15796

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39ab423f06ef
Move CONTENT_FRAME_TIME calculation code into CompositorBridgeParent. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/dad482c7ff92
Use shared CONTENT_FRAME_TIME calculation for non-WebRender. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/89f55d26acaf
Record SVG and UPLOAD specific variants of CONTENT_FRAME_TIME using the vsync based timings. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/65266c77b815
Pass FULL_PAINT_TIME value to CONTENT_FRAME_TIME calculation for non-WR. r=jrmuizel

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/39ab423f06ef
https://hg.mozilla.org/mozilla-central/rev/dad482c7ff92
https://hg.mozilla.org/mozilla-central/rev/89f55d26acaf
https://hg.mozilla.org/mozilla-central/rev/65266c77b815