1518055 - Cache nsIFrames selected state when possible

Status: NEW

(Core :: DOM: Selection, enhancement, P2)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: selection_flag_cache_4.diff

It would be nicer to keep the flags in nsIFrame only, but it has only one spare bit.
So the patch doesn't cache the state per textframe but per node, if it has only one frame.

This relies on Selection (SelectFrames()) and nsRange (InvalidateAllFrames()) to call InvalidateFrameSubtree on the common ancestor.



(slow selection painting is different bug, bug 1518052)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af6810cac5e2350534021c1a018de951d4b3dc11

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9034638 [details] [diff] [review]
selection_flag_cache_4.diff

Crap, bug 1305957 used the last free bit. Back to drawing board.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: selection_flag_cache_5.diff