Closed Bug 1518077 Opened 9 months ago Closed 9 months ago

Improve telemetry for compartment/realm counts

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(3 files)

The MEMORY_JS_COMPARTMENTS_{SYSTEM,USER} reporter now reports number of realms. We should probably change this back to number of system/non-system compartments and add separate MEMORY_JS_REALMS_{SYSTEM,USER} reporters for the realm counts.
Attached file request.md
Attachment #9034959 - Flags: review?(chutten)

Comment on attachment 9034959 [details]
request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. These collections are Telemetry so are documented in their definitions file (Histograms.json), the Probe Dictionary, and on telemetry.mozilla.org's Measurement Dashboards.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. These collections are Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes. :jandem is responsible for these metrics.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical. (though the number of realms may be tied to the number of tabs or other user interaction features the relationship is an implementation detail and subject to change.)

Is the data collection request for default-on or default-off?

Default on, prerelease channels only.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. These collections are permanent.


Result: datareview+

Attachment #9034959 - Flags: review?(chutten) → review+

Thanks Chris!

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/642591e716e1
part 1 - Fix MEMORY_JS_COMPARTMENTS_{USER,SYSTEM} telemetry to count number of compartments instead of realms. r=njn
https://hg.mozilla.org/integration/autoland/rev/270584ef33a9
part 2 - Add MEMORY_JS_REALMS_{USER,SYSTEM} similar to the MEMORY_JS_COMPARTMENTS_{USER,SYSTEM} counts. r=njn,chutten
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.