1518094 - Intermittent toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html with 14 fails

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Vinothkumar Nagasayanan [:vinoth]]

toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html test fails everytime locally(Mac OS) regardless of making any changes.

ERROR LOG:

0:07.02 GECKO(96166) JavaScript error: file:///Users/vinothkumar/src2/mozilla-central/obj-x86_64-apple-darwin18.0.0/dist/Nightly.app/Contents/Resources/components/storage-json.js, line 444: TypeError: login is null
 0:07.02 GECKO(96166) JavaScript error: file:///Users/vinothkumar/src2/mozilla-central/obj-x86_64-apple-darwin18.0.0/dist/Nightly.app/Contents/Resources/components/nsLoginManager.js, line 347: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "login is null" {file: "file:///Users/vinothkumar/src2/mozilla-central/obj-x86_64-apple-darwin18.0.0/dist/Nightly.app/Contents/Resources/components/storage-json.js" line: 444}]'[JavaScript Error: "login is null" {file: "file:///Users/vinothkumar/src2/mozilla-central/obj-x86_64-apple-darwin18.0.0/dist/Nightly.app/Contents/Resources/components/storage-json.js" line: 444}]' when calling method: [nsILoginManagerStorage::removeLogin]
 0:07.02 GECKO(96166) JavaScript error: file:///Users/vinothkumar/src2/mozilla-central/obj-x86_64-apple-darwin18.0.0/dist/Nightly.app/Contents/Resources/components/nsLoginManager.js, line 347: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "login is null" {file: "file:///Users/vinothkumar/src2/mozilla-central/obj-x86_64-apple-darwin18.0.0/dist/Nightly.app/Contents/Resources/components/storage-json.js" line: 444}]'[JavaScript Error: "login is null" {file: "file:///Users/vinothkumar/src2/mozilla-central/obj-x86_64-apple-darwin18.0.0/dist/Nightly.app/Contents/Resources/components/storage-json.js" line: 444}]' when calling method: [nsILoginManagerStorage::removeLogin]
 0:07.02 INFO AddTask.js | Leaving test test_form1_check_only_entry_remaining
 0:07.02 INFO AddTask.js | Entering test test_form2
 0:07.02 FAIL Checking form2 username is: singleuser5 - got "", expected "singleuser5"
    SimpleTest.is@SimpleTest/SimpleTest.js:320:5
    checkACForm@toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html:195:3
    test_form2@toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html:575:3
    async*nextTick/<@SimpleTest/AddTask.js:70:34
    async*nextTick@SimpleTest/AddTask.js:44:10
    setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:684:12
    add_task@SimpleTest/AddTask.js:30:7
    @toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html:209:1
 0:07.02 FAIL Checking form2 password is: singlepass5 - got "", expected "singlepass5"
    SimpleTest.is@SimpleTest/SimpleTest.js:320:5
    checkACForm@toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html:196:3
    test_form2@toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html:575:3
    async*nextTick/<@SimpleTest/AddTask.js:70:34
    async*nextTick@SimpleTest/AddTask.js:44:10
    setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:684:12
    add_task@SimpleTest/AddTask.js:30:7
    @toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html:209:1

Comment 1

[Matthew N. [:MattN]]

Hmm… I haven't seen any other reports of this and we don't have automatic failures in automation on macOS either. What command are you using to see this test fail?

Comment 2

[Vinothkumar Nagasayanan [:vinoth]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Hmm… I haven't seen any other reports of this and we don't have automatic failures in automation on macOS either. What command are you using to see this test fail?

I am using this command,
./mach mochitest toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html

Correct me if I need to use something else.

Comment 3

[Matthew N. [:MattN]]

It seems like there is a race with setting prefs like signon.autofillForms.http=true

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1518094 - Fix test_*_autocomplete.html autofill failures by setting prefs sooner. r=jaws

Move prefs from pwmgr_common.js to mochitest.ini and remove redundant calls to set those same prefs.

Comment 5

[Matthew N. [:MattN]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=038e9d2fc019eb7601b1e0f9e94cd11343df7f12

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44d70ce90650
Fix test_*_autocomplete.html autofill failures by setting prefs sooner. r=jaws

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/44d70ce90650