Rename LengthOrPercentage.

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(2 attachments)

LengthOrPercentage is a misnomer, since it represents a <length-percentage> value, not a <length> | <percentage>
Assignee

Comment 1

5 months ago
It does not represent `<length> | <percentage>`, but `<length-percentage>`, so
`LengthOrPercentage` is not the right name.

This patch is totally autogenerated using:

rg 'LengthOrPercentage' servo | cut -d : -f 1 | sort | uniq > files
for file in $(cat files); do sed -i "s#LengthOrPercentage#LengthPercentage#g" $file; done
Assignee

Comment 2

5 months ago
lop is not an acceptable variable name for LengthPercentage.

Depends on D15812

Comment 3

5 months ago
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ca89c98ff5d
Rename LengthOrPercentage to LengthPercentage. r=jwatt#style
https://hg.mozilla.org/integration/autoland/rev/06c59ba512ba
Manually rename some variables. r=jwatt#style

Comment 4

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7ca89c98ff5d
https://hg.mozilla.org/mozilla-central/rev/06c59ba512ba
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.