Closed Bug 1518134 Opened 1 year ago Closed 1 year ago

Extend paint phase histogram lifetime

Categories

(Core :: Graphics, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: miko, Assigned: miko)

References

Details

Attachments

(2 files)

The histograms CONTENT_LARGE_PAINT_PHASE_WEIGHT and CONTENT_SMALL_PAINT_PHASE_WEIGHT expired on 66.
Because these are useful histograms for measuring the weight of display list building during painting, I would like to extend these until 72. This will help to measure progress of improving display list building performance.
Attached file data-review-request.md
Data review request, mostly the same as in bug 1309442.
Attachment #9034741 - Flags: review?(chutten)

Comment on attachment 9034741 [details]
data-review-request.md

Preliminary note:
Have there been any useful conclusions drawn from these collections over their initial collection period?

DATA COLLECTION REVIEW RESPONSE

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. These collections are Telemetry so they are documented in their definitions files (Histograms.json), the Probe Dictionary, and the telemetry.mozilla.org Measurement Dashboards.

Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. These collections are Telemetry so can be controlled by Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, expires in Firefox 72.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical

Is the data collection request for default-on or default-off?

Default on for prerelease channels only.

Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

Is the data collection covered by the existing Firefox privacy notice? 

Yes.

Does there need to be a check-in in the future to determine whether to renew the data? 

Yes. :miko will be responsible for renewing or removing the probe before it expires in Firefox 72.


Result: datareview+

Attachment #9034741 - Flags: review?(chutten) → review+
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/11ed05bc88ff
Extend paint phase histogram lifetime r=chutten

(In reply to Chris H-C :chutten from comment #3)

Comment on attachment 9034741 [details]
data-review-request.md

Preliminary note:
Have there been any useful conclusions drawn from these collections over their initial collection period?

The initial collection period helped us to confirm display list building as good target for performance improvement work.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.