import OPML feed file removes slash from title

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: thomas.seeling, Assigned: alta88)

Tracking

Thunderbird 66.0

Thunderbird Tracking Flags

(thunderbird_esr6066+ fixed, thunderbird66 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36

Steps to reproduce:

Open subscription manager for Blogs+RSS Feeds.
Add a subfolder and add RSS feed definition to that subfolder.
Example: https://www.reddit.com/r/Jokes.rss
Enter slash in title of subfolder (e.g. "/r/Jokes").
Export OPML file.
Use other instance of thunderbird (e.g. different machine) to import file.


Actual results:

Imported Feeds loose slash in titles.
Example: title is rJokes with / removed.


Expected results:

Title should be the same as when export happened.
Example: /r/Jokes.

Updated

5 months ago
Component: Untriaged → Feed Reader
Product: Thunderbird → MailNews Core
Assignee

Comment 1

5 months ago

If exported from Tb, the ompl folder display name is already clean. There's little practical risk to relaxing this restriction, and an undue penalty for legitimate names as safe disk names will be created from display names.

Assignee: nobody → alta88
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #9038422 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9038422 [details] [diff] [review]
foldername.patch

Review of attachment 9038422 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think you can assume it's a Thunderbird generated OPML file. 
Seems it works things out anyway so, r=mkmelin
Attachment #9038422 - Flags: review?(mkmelin+mozilla) → review+
Assignee

Comment 3

5 months ago

of course, that's why it was overly strict to begin with.

Keywords: checkin-needed

Comment 4

5 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a65a5f531d40
Don't sanitize folder names from ompl import. r=mkmelin

Status: NEW → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Comment 5

5 months ago

You want to backport this?

Target Milestone: --- → Thunderbird 66.0
Assignee

Comment 6

5 months ago

why not, it's fairly risk free.

Updated

5 months ago
Attachment #9038422 - Flags: approval-comm-esr60?
Attachment #9038422 - Flags: approval-comm-beta+

Comment 7

4 months ago
Comment on attachment 9038422 [details] [diff] [review]
foldername.patch

Not doing another TB 65 beta and the change is already in TB 66 (beta).
Attachment #9038422 - Flags: approval-comm-beta+

Updated

3 months ago
Attachment #9038422 - Flags: approval-comm-esr60? → approval-comm-esr60+
You need to log in before you can comment on or make changes to this bug.