1518159 - DevTools XUL searchboxes look broken

Status: VERIFIED FIXED

(DevTools :: Framework, defect, P2)

Description

[Tim Nguyen :ntim]

Attachment: Screen Shot 2019-01-07 at 15.43.20.png

Comment 1

[Tim Nguyen :ntim]

The issue is caused by bug 1473927 which increased the specificity of the toolkit textbox[type=search] rules.

Since no-one is maintaining the DevTools XUL panels (hence having this bug slip in 3 releases), I think it's just more simple to stop using [type=search], and remove the associated DevTools styling.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1518159 - Remove usages of and support for XUL textbox[type='search'] in DevTools. r=pbro

Comment 3

[Tim Nguyen :ntim]

Note that the only side-effects of not using textbox[type=search] are simply:
- No built-in clear button
- No "timeout" feature (waiting for the 200/500ms timeout to pass before actually searching)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aab09dc65108
Remove usages of and support for XUL textbox[type='search'] in DevTools. r=pbro

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 9034751 [details]
Bug 1518159 - Remove usages of and support for XUL textbox[type='search'] in DevTools. r=pbro

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1473927

User impact if declined: See attachment 9034747 [details]

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: See attachment 9034747 [details]

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Trivial change, though comes with a approved small feature loss

String changes made/needed: none

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aab09dc65108

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9034751 [details]
Bug 1518159 - Remove usages of and support for XUL textbox[type='search'] in DevTools. r=pbro

[Triage Comment]
Removes the use of a feature that isn't well-supported and regressed in Fx64. Might as well take it now for Fx65 rather than letting it be broken in another release before the removal ships with 66. Approved for 65.0b10.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fad62ad328d

Comment 9

[Cristian Fogel [:cfogel]]

Verified the fix with 66.0a1 (2019-01-10) on Windows 10, macOS 10.13, Ubuntu 16.04.
65.0b9 indeed appears to still be affected by styling issues.

Comment 10

[Cristian Fogel [:cfogel]]

Fix confirmed for 65.0b10 as well.