Closed Bug 1518170 Opened 1 year ago Closed 1 year ago
Always upload profile output
47 bytes, text/x-phabricator-request
|Details | Review|
Bug 1514288 made it so that during PGO builds we save the terminal output of Firefox into files and save them as artifacts. However, the files don't get uploaded if the task fails. We should upload them regardless so we can see why the profile generation step failed, and perhaps print them out if FirefoxRunner returns a failure code.
You should be able to just write the log to `$UPLOAD_PATH`, which is where we stick artifacts. I did that for the sccache log for similar reasons: https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/client.mk#85-86
In bug 1514288 we started to save the output from running Firefox during PGO builds into log files, but they aren't correctly uploaded if the run fails. We can generate them directly into the artifacts directory so that they are always uploaded. Additionally, the log files are displayed if the run fails so that the error messages are displayed in the log for easier bug categorization.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8d44d6ba5863 Always upload profile run output; r=firefox-build-system-reviewers,chmanchester#firefox-build-system-reviewers
You need to log in before you can comment on or make changes to this bug.