Closed Bug 1518171 Opened 2 years ago Closed 2 years ago

Activity Stream Discovery Stream component feed implementation

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.3 - Jan 7 - 20
Tracking Status
firefox66 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

Details

(Keywords: github-merged)

Attachments

(4 files)

New components like card grid and list need access to feed data. In Discovery Stream each components has a feed, so we need to be able to also cache a variable number of feeds and make sure they get to the correct component and the loading of a page does't look like junk as feeds are coming in.
Assignee: nobody → sdowne
Blocks: 1512725, 1513353
Iteration: --- → 66.3 - Jan 7 - 20
Priority: -- → P1
Severity: normal → enhancement
Whiteboard: github-merged
Whiteboard: github-merged → [github-merged]
Blocks: 1519303
Keywords: github-merged
Whiteboard: [github-merged]
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Steps to test:

  1. Ensure the new tab is the regular version by default.
  2. In about:config, change browser.newtabpage.activity-stream.discoverystream.config to be {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}
  3. In about:config, change browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to be true
  4. Go to about:newtab#devtools-ds and should see something like the screenshot I'm attaching under "layout".
  5. Reset the pref, ensure everything is back to normal.
Attached image layout.png

Test Results :

Tested on -

FF Nightly version 66.0a1 (2019-01-16)

OS : Mac and Windows 10

Followed test steps as provided above, donot see layout as expected.
I'm seeing a different layout on about:newtab#devtools-ds as attached.

Flags: needinfo?(sdowne)

Yeah that's fine, the data changes often, but in general as long as you see something under layout you're fine. It'll look familiar to the screen shot but slightly different. It's an issue if you see nothing.

Flags: needinfo?(sdowne)
Attached image QA.png

QA Results:

Tested on :

FF Nightly version : 66.0a1 (2019-01-18)

OS : Mac and Windows 10

Below are the observations :

  • New tab renders different layout with pref changes, functionality works as expected.
  • about:newtab#devtools-ds has Layout info accurate. (as in attached screenshot "QA.png")
  • After Pref reset, New Tab gets back the default version and functionality works as expected.

Looks good to me.

Thanks,
Brahmini

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.