1518171 - Activity Stream Discovery Stream component feed implementation

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

New components like card grid and list need access to feed data. In Discovery Stream each components has a feed, so we need to be able to also cache a variable number of feeds and make sure they get to the correct component and the loading of a page does't look like junk as feeds are coming in.

Comment 1

[Kate Hudson :k88hudson]

Attachment: GitHub Pull Request

Comment 2

[Ed Lee :Mardak]

https://github.com/mozilla/activity-stream/commit/c90b29e394d1977121d031cc72652382ff9e29d6

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/226b130b6360

Comment 4

[Scott [:thecount] Downe]

Steps to test:

1. Ensure the new tab is the regular version by default.
2. In about:config, change browser.newtabpage.activity-stream.discoverystream.config to be {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}
3. In about:config, change browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to be true
4. Go to about:newtab#devtools-ds and should see something like the screenshot I'm attaching under "layout".
5. Reset the pref, ensure everything is back to normal.

Comment 5

[Scott [:thecount] Downe]

Attachment: layout.png

Comment 6

[Brahmini Nagabandi]

Attachment: Screen Shot 2019-01-16 at 2.12.31 PM.png

Test Results :

Tested on -

FF Nightly version 66.0a1 (2019-01-16)

OS : Mac and Windows 10

Followed test steps as provided above, donot see layout as expected.
I'm seeing a different layout on about:newtab#devtools-ds as attached.

Comment 7

[Scott [:thecount] Downe]

Yeah that's fine, the data changes often, but in general as long as you see something under layout you're fine. It'll look familiar to the screen shot but slightly different. It's an issue if you see nothing.

Comment 8

[Brahmini Nagabandi]

Attachment: QA.png

QA Results:

Tested on :

FF Nightly version : 66.0a1 (2019-01-18)

OS : Mac and Windows 10

Below are the observations :

• New tab renders different layout with pref changes, functionality works as expected.
• about:newtab#devtools-ds has Layout info accurate. (as in attached screenshot "QA.png")
• After Pref reset, New Tab gets back the default version and functionality works as expected.

Looks good to me.

Thanks,
Brahmini