1518213 - creating MediaElementSourceNode in browser test would leak windows and docshell

Status: NEW

(Core :: Web Audio, enhancement, P2)

Description

[Alastor Wu [:alwu]]

Fork from bug1513733. When I ws testing my test, I found that there are always leaking 2 windows and 1 doshell. So I made a simple browser test [1] in which I just create a MediaElementSourceNode and connect it with AudioContext, and then that test would leak the window [2] in the test-verify mode [3].

[1] https://hg.mozilla.org/try/rev/4df32afdc49527ceab171fdea93970e1db447fac

[2] https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220115582&repo=try&lineNumber=1599

[3] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5437e3d2b7a80f96adf8029dc37b5e825ccbb0b

Comment 1

[Andreas Pehrson [:pehrsons]]

I can debug this. The logs are not too exhaustive but I'm assuming we're leaking a DecodedStream or AudioNode or some such, which in turn is keeping things alive with a cycle.

Comment 2

[Alastor Wu [:alwu]]

File video is here.
https://searchfox.org/mozilla-central/source/toolkit/content/tests/browser/file_video.html

Comment 3

[Andreas Pehrson [:pehrsons]]

Thanks. I just noticed after posting the comment that it was an old file. Tried to sneak it through with a comment edit but I guess the email was already out 😅

Comment 4

[Andreas Pehrson [:pehrsons]]

I could not reproduce this locally with ./mach test toolkit/content/tests/browser/browser_test_leaking.js --verify --disable-e10s --headless --keep-open=false.

Comment 5

[Alastor Wu [:alwu]]

(In reply to Andreas Pehrson [:pehrsons] from comment #4)

I could not reproduce this locally with ./mach test toolkit/content/tests/browser/browser_test_leaking.js --verify --disable-e10s --headless --keep-open=false.

Neither can I, I can only reproduce this fail on try-server, but it would happen 100% everytime I push it to try.