Use Intl.NumberFormat objects to format numbers in about:memory rather than hand-rolling formatting code or using toLocaleString that will create a fresh formatter object every time it's called
RESOLVED
FIXED
in Firefox 66
Status
()
People
(Reporter: Waldo, Assigned: Waldo)
Tracking
Firefox Tracking Flags
(firefox66 fixed)
Details
Attachments
(1 attachment)
|
6.90 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Assignee) | |
Comment 1•3 months ago
|
||
I would much appreciate if you could (if this patch appears right) r+, then test it for me, then land it if you could. This is a bit afield of my area of work, so I really can't spare effort here. :-)
Attachment #9034808 -
Flags: review?(cam)
|
||
Comment 2•3 months ago
|
||
On current mozilla-central we spend 19 ms under formatNum for a particular, large memory report file, and with this patch it's 29 ms. The time is still pretty reasonable so I think we should take it. Thanks!
|
|
||
Comment 3•3 months ago
|
||
|
|
||
Updated•3 months ago
|
Attachment #9034808 -
Flags: review?(cam) → review+
|
|
||
Updated•3 months ago
|
Keywords: checkin-needed
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3131c1c9f3c5
Use Intl.NumberFormat objects to format numbers in about:memory rather than hand-rolling formatting code or using toLocaleString that will create a fresh formatter object every time it's called. r=heycam
Keywords: checkin-needed
|
||
Comment 5•3 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.