Closed Bug 1518264 Opened 5 years ago Closed 5 years ago

New non-monospace comments styled with way too small a font size

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: dylan)

References

Details

Attachments

(2 files, 3 obsolete files)

The stylesheet has:

font-size: 13px;
font-family: "Fira Sans", "Open Sans", "Helvetica Neue", Arial, Helvetica, sans-serif;

While a monospace font at 13px is sort of OK to read (and in fact that's the default in browsers in many cases), a 13px proportional font is way too small in many cases. Certainly I can barely read the newly-proportional bug comments.

Is there a reason we're using anything other than the user's chosen default font size here? We really shouldn't be, for bodies of text the user is expected to read.

Group: bmo-infra

How about font-size: medium; font-family: system?

Flags: needinfo?(kohei.yoshino)
Flags: needinfo?(ehumphries)

Yes, and I think that font-family should be

font-family: -apple-system, BlinkMacSystemFont,
    "Segoe UI", "Roboto", "Oxygen",
    "Ubuntu", "Cantarell", "Fira Sans",
    "Droid Sans", "Helvetica Neue", sans-serif;
Flags: needinfo?(ehumphries)
Attached image Option A: Identical to github (obsolete) —

This is the font and font-size of github comments, which is 14px.

Assignee: nobody → dylan

Github also has line-height styling that makes things a bit more readable at small font sizes by increasing the spacing between lines, fwiw.

This is what we're going with the patch.

Attachment #9034821 - Attachment is obsolete: true
Attachment #9034896 - Attachment is obsolete: true
Attachment #9034897 - Attachment is obsolete: true
Attachment #9034898 - Attachment description: GitHub Pull Request: Option A variant → GitHub Pull Request: Option C
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

I'm guessing this is not deployed yet?

In any case, while the font in Option C is larger, it is still hard to read, due to huge line length of ~160 characters, which is twice the recommended size.

https://en.wikipedia.org/wiki/Line_length

Github's line length is 35% shorter at around 100 characters per line, copying only some aspects of typography might not be the best way to design for readability.

So we'll copy that too. Note that good percentage of users appear to use bugzilla in a narrow context and text does wrap shorter in those smaller viewports (as reported by google analytics)

Blocks: 1518528
Flags: needinfo?(kohei.yoshino)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: