1518292 - Environment in JEXL context should be `env`, not `environment`

Status: RESOLVED FIXED

(Firefox :: Normandy Client, defect)

Description

[Ethan Glasser-Camp (:glasserc)]

In bug 1477255, I filed a patch creating an alias called environment, but per discussion on the bug, it should instead be called env.

Fortunately, I don't think any recipes use this yet so it should be easy to fix.

Comment 1

[Ethan Glasser-Camp (:glasserc)]

leplatrem: The original bug had a stated goal of Normandy and Remote Settings being compatible with what the context was named. I don't think any Normandy recipes use environment yet so we can switch it to env very easily. What about Remote Settings? I see there's already support for environment -- do you know if any settings use that? If so, I guess we need to maintain that for backwards compatibility, at least on the Remote Settings side.

Comment 2

[Mathieu Leplatre [:leplatrem]]

We don't have any settings entries that have JEXL experessions, and AFAIK none of our current use-cases are designed to leverage them.

I would say that we're safe to rename it to env.

Comment 3

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1518292: use env instead of environment in JEXL context

Comment 4

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=362471ae0392890cb8ff232df750234239a612d5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0858dddedf9
use env instead of environment in JEXL context r=Gijs

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b0858dddedf9