1518293 - Revise appearance of "Block Lists" popup in about:preferences

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Arthur Edelstein [:arthur]]

We need to revise the copy of the "Block Lists" popup, and add an explanatory link. Images will attached shortly.

Comment 1

[Arthur Edelstein [:arthur]]

Attachment: current_appearance

Comment 2

[Arthur Edelstein [:arthur]]

Attachment: new_appearance

Comment 3

[Arthur Edelstein [:arthur]]

pdol mentioned: "It's totally fine to rename these lists while we're at it if we want to avoid confusion between the Strict setting and the Strict list."

Comment 4

[Tanvi Vyas[:tanvi]]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1510555.

Comment 5

[Arthur Edelstein [:arthur]]

The link should be to https://disconnect.me

Comment 6

[Betsy Mikel [:betsymi]]

Here's copy for this component:

Choose the list Firefox uses to block online trackers. Lists provided by Disconnect. [Link to Disconnect: https://disconnect.me]

Level 1 block list (Recommended). Allows some trackers so fewer websites break.
Level 2 block list. Blocks all detected trackers. Some websites or content may not load properly.

See also: bug 1510555

Comment 7

[Johann Hofmann [:johannh]]

Attachment: Bug 1518293 - Update copy for blocklist settings in about:preferences. r=ewright,flod

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46b19ac773fa
Update copy for blocklist settings in about:preferences. r=ewright,flod

Comment 9

[Ed Lee :Mardak]

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223552507&repo=autoland&lineNumber=5210

TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js | Should be in search results -

The test was searching for "block Web elements" that was removed here. see screenshot:

https://taskcluster-artifacts.net/LKZ9XUr_QaazrKgk6m7i2Q/0/public/test_info//mozilla-test-fail-screenshot_WElIIe.png

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for browser chrome failures on browser_search_subdialogs_within_preferences_6

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=browser%2Cchrome&revision=46b19ac773fa06edea4e04f9ee945852c0d9e867&selectedJob=223555082

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223555082&repo=autoland&lineNumber=5838

Backout link: https://hg.mozilla.org/integration/autoland/rev/5c5222d1050a7567501f466525273e2f4ba7fc73

Comment 11

[Johann Hofmann [:johannh]]

Whoops

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29e05059db5c
Update copy for blocklist settings in about:preferences. r=ewright,flod

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/29e05059db5c