1518300 - Add JWK/JWE methods to jwcrypto

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Edouard Oger [:eoger]]

This is a part of bug 1490671 that we would like to land early.
The following patch includes two new generateJWE/decryptJWE methods that allow working on a small subset of the JWE encryption standard.
The other part of the patch is composed of replacing hand-rolled encryption methods by WebCrypto.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1518300 - Refactor CryptoUtils and add JWK/JWE methods to jwcrypto.

Comment 2

[Edouard Oger [:eoger]]

Paul rfkelly recommended me to ni? you: could you nominate someone to review this?

Comment 3

[Edouard Oger [:eoger]]

We'll discuss this tomorrow in the security review meeting.

Comment 4

[Paul Theriault [:pauljt] (no longer reading bugmail)]

FWIW, I did have a look at this, but only a brief one. The js looked ok common firefox js flaws perspective, but I haven't verified the crypto at all. Im not familiar with JWE, and I got as far as reading about attacks against ECDH-ES [1] before realising I was out of my depth. We can try to figure out if we have someone more appropriate in the meeting.

[1] https://blogs.adobe.com/security/2017/03/critical-vulnerability-uncovered-in-json-encryption.html

Comment 5

[Ryan Kelly [:rfkelly]]

FWIW it's my belief that crypto.subtle.importKey will reject invalid keys and protect against the above attack, but we should definitely confirm this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7befa4aa3c7f
Refactor CryptoUtils and add JWK/JWE methods to jwcrypto. r=rfkelly,tjr

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7befa4aa3c7f