1518303 - Comments on splinter patches are misformatted with markdown styling

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1515113#c15 for example. The formatting makes no sense when applied to patch context.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

In case you can't see that comment (because it's a secure bug), the problem is that adding a comment on a splinter patch quotes some of the patch which has leading + and - characters. And then that gets turned into a bulleted list in markdown mode.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

I've edited that comment so the diff is wrapped in ```patch and ```, which is could probably be done automatically. Note all users with editbugs may edit their own comments now.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Cool, didn't know you can now edit comments. \o/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I was going to report the same thing (see bug 1518201).

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Splinter comments will be non-markdown, based on the presence of the magic splinter header. I've already made this tweak to the 13 splinter comments from today.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Attachment: GitHub Pull Request