Closed Bug 1518326 Opened 1 year ago Closed 1 year ago

Add timezone sanity check to regions and reset region pref with next Firefox

Categories

(Firefox :: Search, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 66
Tracking Status
firefox65 - wontfix
firefox66 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

We should add a sanity check so if we get US for a region, we make sure it's in a US timezone.

After doing this, we should do a region reset.

See part of the patch here:

https://phabricator.services.mozilla.com/D2527

[Tracking Requested - why for this release]: Should allow to get back some searches/revenue we were missing in the wrong regions.

Low risk.

In theory we could also check against:

Intl.DateTimeFormat().resolvedOptions().timeZone

This would save us from getting accidental South America. Not sure if that's worth it?

I'll consider a patch for uplift, but I don't think we need to track this either.

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/d7f17000fa1c
Sanity check US region against timezone. r=adw
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Per discussion with Mike on IRC, letting this ride the trains.

You need to log in before you can comment on or make changes to this bug.