Closed
Bug 1518326
Opened 5 years ago
Closed 5 years ago
Add timezone sanity check to regions and reset region pref with next Firefox
Categories
(Firefox :: Search, enhancement, P1)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 66
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
We should add a sanity check so if we get US for a region, we make sure it's in a US timezone.
After doing this, we should do a region reset.
See part of the patch here:
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
[Tracking Requested - why for this release]: Should allow to get back some searches/revenue we were missing in the wrong regions.
Low risk.
tracking-firefox65:
--- → ?
|
|
Assignee | |
Comment 3•5 years ago
|
||
In theory we could also check against:
Intl.DateTimeFormat().resolvedOptions().timeZone
This would save us from getting accidental South America. Not sure if that's worth it?
|
||
Comment 4•5 years ago
|
||
I'll consider a patch for uplift, but I don't think we need to track this either.
status-firefox65:
--- → fix-optional
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/d7f17000fa1c Sanity check US region against timezone. r=adw
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
||
Comment 7•5 years ago
|
||
Per discussion with Mike on IRC, letting this ride the trains.
You need to log in
before you can comment on or make changes to this bug.
Description
•