Tidy up a few things in dom/animation

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(7 attachments)

(Assignee)

Description

3 months ago

While working on bug 1253476 I noticed a few things that need to be tidied up. Filing this bug so those fixes can be landed separately.

(Assignee)

Updated

3 months ago
Summary: Tidy up a few things in Animation.h etc. → Tidy up a few things in dom/animation
(Assignee)

Comment 1

3 months ago
This arranges related declarations by function as opposed to trying to
distinguish between functions that are Web-facing and those that are not.

The order still corresponds to the order in the spec[1] however.

[1] https://drafts.csswg.org/web-animations-1/#the-animation-interface
(Assignee)

Comment 2

3 months ago
As of bug 1203009 / changeset 37b6deedaab6 and per spec, we no longer reset the
animation index when an Animation re-enters the idle state and kNoIndex is no
longer defined.

Depends on D15898
(Assignee)

Comment 6

3 months ago
Bug 1517241 renamed nsIDocument to mozilla::dom::Document but unfortunately in
the process it messed up the ordering of includes which, according to the coding
style[1], should be alphabetically sorted.

Also, in TimingParams.cpp it didn't add the dom::* prefix so when the unified
build chunking changes, if the "using namespace mozilla::dom" declaration
disappears from the chunk, it will fail to build.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices

Depends on D15902

Comment 8

3 months ago
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ff9725e0c3a
Shuffle definitions in Animation.h; r=hiro
https://hg.mozilla.org/integration/autoland/rev/d497b0f223c9
Remove obsolete comment in Animation.h about kNoIndex; r=hiro
https://hg.mozilla.org/integration/autoland/rev/c19867adc2c7
Mark GetKeyframes and GetTargetComputedStyle as const; r=hiro
https://hg.mozilla.org/integration/autoland/rev/b1f4b8412f62
Drop unused aEffectSet parameter from EffectCompositor::AllowCompositorAnimationsOnFrame; r=hiro
https://hg.mozilla.org/integration/autoland/rev/5d75876949f3
Move a couple of bool members next to each other in KeyframeEffect.h so they can be packed together; r=hiro
https://hg.mozilla.org/integration/autoland/rev/5f9c8df9984b
Fix a bunch of fallout from changes to mozilla::dom::Document; r=hiro
https://hg.mozilla.org/integration/autoland/rev/4ad5b70956ab
Add missing dom:: declaration to PendingAnimationTracker.cpp; r=hiro
You need to log in before you can comment on or make changes to this bug.