1518384 - Some files depend on |using namespace mozilla| and |using namespace dom| in other cpp file to use Document

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When I'm working on renaming a find in dom/base, I hit this bug.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

s/find/file

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed1c7aa0eac431ece663b4c3a421f1ade7fe2f1f

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1518384 - Fix some lines which depend on |using namespace mozilla| and |using namespace mozilla::dom| in Document.cpp and Element.cpp

After landing bug 1517241, some lines in Document.cpp and Element.cpp depend on
|using namespace mozilla| and |using namespace mozilla::dom| of *different*
cpp files.  Therefore, when you rename some cpp files in dom/base, you'll
hit compile error.

This patch fixes the dependency with moving some classes into mozilla namespace
and adding |mozilla::| or |dom::| to a couple of lines.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54f18c480711
Fix some lines which depend on |using namespace mozilla| and |using namespace mozilla::dom| in Document.cpp and Element.cpp r=smaug

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Thanks for fixing this Masayuki, and sorry :(

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/54f18c480711

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

Thanks for fixing this Masayuki, and sorry :(

No problem. But I think that we should stop using |using namespace foo| even in cpp files if they are unified. I usually hit this kind of bugs when I try to rename cpp files.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900)(sick) from comment #7)

No problem. But I think that we should stop using |using namespace foo| even in cpp files if they are unified. I usually hit this kind of bugs when I try to rename cpp files.

Yeah, or at least test non-unified builds in automation? That might be easier, though I recall that being frowned upon a few times.