caret should not move into even more ligated Emoji sequences

RESOLVED FIXED in Firefox 66

Status

()

defect
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: thomas.a.levy, Assigned: jfkthame)

Tracking

64 Branch
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

go to the url "data:text/html;charset=utf-8,<h1 contenteditable>%F0%9F%92%82%E2%80%8D%E2%99%80%EF%B8%8F", place your cursor to the right of the emoji and press the left arrow key

Actual results:

Cursor is midway through the female guard emoji

Expected results:

Cursor goes to the left of the female guard emoji.

Reporter

Updated

5 months ago
Component: Untriaged → Layout: Text and Fonts
Product: Firefox → Core
Reporter

Comment 1

5 months ago

I believe this is unfinished business from bug #1484094

Assignee

Comment 2

5 months ago

Ah, I see... this will also apply to emoji that are constructed of [man/woman] + zwj + [occupation] + vs-16, such as the sequences for "man/woman health worker", "man/woman judge", etc.

Assignee

Comment 3

5 months ago
The patch in bug 1484094 didn't consider the case where the trailing component of the ligature was not an emoji-default-presentation character, but a legacy BMP symbol (such as the gender symbols, or certain occupations like medical or judge) that is emoji-fied by the addition of VS16. So this patch adds a check for this type of sequence, and prevents the cursor being placed there.
Attachment #9034953 - Flags: review?(m_kato)
Assignee

Updated

5 months ago
Assignee: nobody → jfkthame
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee

Updated

5 months ago
Priority: -- → P3
Attachment #9034953 - Flags: review?(m_kato) → review+

Comment 4

5 months ago
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a43422e9e4da
Exclude caret position within ligated emoji sequence where the second component was a BMP symbol + VS16. r=m_kato

Comment 5

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
QA Whiteboard: [good first verify]

I have reproduced this bug with Nightly 66.0a1 (2019-01-07) on Windows 10, 64 Bit. This fix of this bug is verified with latest Beta 66.0b5!

Build ID : 20190204181317
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

QA Whiteboard: [good first verify] → [good first verify] [bugday-20190206]
Assignee

Updated

4 months ago
See Also: → 1527387
You need to log in before you can comment on or make changes to this bug.